From: David Tardon <dtardon@redhat.com>
Date: Tue, 28 Mar 2023 11:33:48 +0000 (+0200)
Subject: portabled-bus: use CLEANUP_ARRAY
X-Git-Tag: v254-rc1~752^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0dab8d5dc7828931f1679f51004359ae7e38d546;p=thirdparty%2Fsystemd.git

portabled-bus: use CLEANUP_ARRAY
---

diff --git a/src/portable/portabled-bus.c b/src/portable/portabled-bus.c
index 768964231a1..0d5518060eb 100644
--- a/src/portable/portabled-bus.c
+++ b/src/portable/portabled-bus.c
@@ -281,6 +281,8 @@ static int method_detach_image(sd_bus_message *message, void *userdata, sd_bus_e
 
         assert(message);
 
+        CLEANUP_ARRAY(changes, n_changes, portable_changes_free);
+
         /* Note that we do not redirect detaching to the image object here, because we want to allow that users can
          * detach already deleted images too, in case the user already deleted an image before properly detaching
          * it. */
@@ -339,13 +341,9 @@ static int method_detach_image(sd_bus_message *message, void *userdata, sd_bus_e
                         &n_changes,
                         error);
         if (r < 0)
-                goto finish;
-
-        r = reply_portable_changes(message, changes, n_changes);
+                return r;
 
-finish:
-        portable_changes_free(changes, n_changes);
-        return r;
+        return reply_portable_changes(message, changes, n_changes);
 }
 
 static int method_reattach_image(sd_bus_message *message, void *userdata, sd_bus_error *error) {