From: Victor Julien <victor@inliniac.net>
Date: Wed, 24 Feb 2016 09:50:06 +0000 (+0100)
Subject: flowbits: optimize set and remove
X-Git-Tag: suricata-3.0.1RC1~112
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0dbbe016d61ed87cabb90887fdc51b340facfa25;p=thirdparty%2Fsuricata.git

flowbits: optimize set and remove
---

diff --git a/src/flow-bit.c b/src/flow-bit.c
index 2e52b9ef1a..934d485996 100644
--- a/src/flow-bit.c
+++ b/src/flow-bit.c
@@ -105,31 +105,25 @@ static void FlowBitRemove(Flow *f, uint16_t idx)
 
 void FlowBitSetNoLock(Flow *f, uint16_t idx)
 {
-    FlowBit *fb = FlowBitGet(f, idx);
-    if (fb == NULL) {
-        FlowBitAdd(f, idx);
-    }
+    FlowBitAdd(f, idx);
 }
 
 void FlowBitSet(Flow *f, uint16_t idx)
 {
     FLOWLOCK_WRLOCK(f);
-    FlowBitSetNoLock(f, idx);
+    FlowBitAdd(f, idx);
     FLOWLOCK_UNLOCK(f);
 }
 
 void FlowBitUnsetNoLock(Flow *f, uint16_t idx)
 {
-    FlowBit *fb = FlowBitGet(f, idx);
-    if (fb != NULL) {
-        FlowBitRemove(f, idx);
-    }
+    FlowBitRemove(f, idx);
 }
 
 void FlowBitUnset(Flow *f, uint16_t idx)
 {
     FLOWLOCK_WRLOCK(f);
-    FlowBitUnsetNoLock(f, idx);
+    FlowBitRemove(f, idx);
     FLOWLOCK_UNLOCK(f);
 }