From: Jan Beulich <jbeulich@suse.com>
Date: Mon, 10 Nov 2025 10:36:25 +0000 (+0100)
Subject: bfd/ELF: _bfd_elf_ppc_at_tls_transform() is exposed to gas
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ded1882eceeefd225bf752b7896c0a877c0d39f;p=thirdparty%2Fbinutils-gdb.git

bfd/ELF: _bfd_elf_ppc_at_tls_transform() is exposed to gas

As a non-private function, it shouldn't have a "_bfd_" prefix, but merely
a "bfd_" one. Hence commit 50efe229ddf5 ("bfd/ELF: mark internal functions
hidden") also wrongly added ATTRIBUTE_HIDDEN to it.
---

diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index 41aee298b96..e7ee074f1c7 100644
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -2916,8 +2916,8 @@ extern Elf_Internal_Phdr * _bfd_elf_find_segment_containing_section
   (bfd * abfd, asection * section) ATTRIBUTE_HIDDEN;
 
 /* PowerPC @tls opcode transform/validate.  */
-extern unsigned int _bfd_elf_ppc_at_tls_transform
-  (unsigned int, unsigned int) ATTRIBUTE_HIDDEN;
+extern unsigned int bfd_elf_ppc_at_tls_transform
+  (unsigned int, unsigned int);
 /* PowerPC @tprel opcode transform/validate.  */
 extern unsigned int _bfd_elf_ppc_at_tprel_transform
   (unsigned int, unsigned int) ATTRIBUTE_HIDDEN;
diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c
index c549b832b7f..f95f7a9c1b5 100644
--- a/bfd/elf32-ppc.c
+++ b/bfd/elf32-ppc.c
@@ -6819,7 +6819,7 @@ is_static_defined (struct elf_link_hash_entry *h)
    REG is non-zero only match an insn with RB or RA equal to REG.  */
 
 unsigned int
-_bfd_elf_ppc_at_tls_transform (unsigned int insn, unsigned int reg)
+bfd_elf_ppc_at_tls_transform (unsigned int insn, unsigned int reg)
 {
   unsigned int rtra;
 
@@ -7169,7 +7169,7 @@ ppc_elf_relocate_section (bfd *output_bfd,
 	      bfd_vma insn;
 
 	      insn = bfd_get_32 (input_bfd, contents + rel->r_offset);
-	      insn = _bfd_elf_ppc_at_tls_transform (insn, 2);
+	      insn = bfd_elf_ppc_at_tls_transform (insn, 2);
 	      if (insn == 0)
 		abort ();
 	      bfd_put_32 (input_bfd, insn, contents + rel->r_offset);
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 205cf1511cb..b01b5fc7c83 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -15925,7 +15925,7 @@ ppc64_elf_relocate_section (bfd *output_bfd,
 	      && offset_in_range (input_section, rel->r_offset & ~3, 4))
 	    {
 	      insn = bfd_get_32 (input_bfd, contents + (rel->r_offset & ~3));
-	      insn = _bfd_elf_ppc_at_tls_transform (insn, 13);
+	      insn = bfd_elf_ppc_at_tls_transform (insn, 13);
 	      if (insn == 0)
 		break;
 	      if ((rel->r_offset & 3) == 0)
diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index e2485a4d794..0aee3f70250 100644
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -3648,7 +3648,7 @@ md_assemble (char *str)
 
 		case BFD_RELOC_PPC_TLS:
 		case BFD_RELOC_PPC64_TLS_PCREL:
-		  if (!_bfd_elf_ppc_at_tls_transform (opcode->opcode, 0))
+		  if (!bfd_elf_ppc_at_tls_transform (opcode->opcode, 0))
 		    as_bad (_("@tls may not be used with \"%s\" operands"),
 			    opcode->name);
 		  else if (operand->shift != 11)