From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Mon, 16 May 2016 21:52:00 +0000 (+0100)
Subject: knotty: Fix output buffering issues
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e030c4d074c41859608dab5f3ad26b05f56b306;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

knotty: Fix output buffering issues

We need to flush the footer removal, else it may not be outputted until
the buffer is flushed as part of StreamHandler and this would lead to
it removing the ERROR output just printed which is extremely confusing.

Also ensure the footer is cleared before printing a summary as in
some cases it wasn't being removed, also leading to user confusion.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py
index 85a71f45ec5..08c872e3977 100644
--- a/lib/bb/ui/knotty.py
+++ b/lib/bb/ui/knotty.py
@@ -186,6 +186,7 @@ class TerminalFilter(object):
             lines = self.footer_present
             sys.stdout.write(self.curses.tparm(self.cuu, lines))
             sys.stdout.write(self.curses.tparm(self.ed))
+            sys.stdout.flush()
         self.footer_present = False
 
     def updateFooter(self):
@@ -568,6 +569,7 @@ def main(server, eventHandler, params, tf = TerminalFilter):
             main.shutdown = 2
             return_value = 1
     try:
+        termfilter.clearFooter()
         summary = ""
         if taskfailures:
             summary += pluralise("\nSummary: %s task failed:",