From: Marek Schimara <Marek.Schimara@bull.net>
Date: Wed, 15 Jun 2016 13:48:34 +0000 (+0200)
Subject: src/rrd_modify.c: fix Coverity CID#32406 Logically dead code
X-Git-Tag: v1.7.0~42^2~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e120c4ed78e8568fafef9993581233d6d097128;p=thirdparty%2Frrdtool-1.x.git

src/rrd_modify.c: fix Coverity CID#32406 Logically dead code

        CWE-561 / https://cwe.mitre.org/data/definitions/561.html

        Either
                finalout = rrd_modify_structure == NULL => goto done;
        or
                finalout = rrd_modify_structure != NULL => rc = 0;
---

diff --git a/src/rrd_modify.c b/src/rrd_modify.c
index 86fc47b9..a6a5033f 100644
--- a/src/rrd_modify.c
+++ b/src/rrd_modify.c
@@ -997,10 +997,6 @@ done:
     }
     if (rc != 0) {
 	out = NULL;
-	if (finalout) {
-	    rrd_memory_free(finalout);
-	    free(finalout);
-	}
 	finalout = NULL;
     }