From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 11 Oct 2016 23:22:46 +0000 (-0400)
Subject: Fix a bug in displaying IPv6 addrs in test_op_ipv6_ with --verbose
X-Git-Tag: tor-0.2.9.4-alpha~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e1b228aa6b5ed7665ba5167a2b88924e58fb9b5;p=thirdparty%2Ftor.git

Fix a bug in displaying IPv6 addrs in test_op_ipv6_ with --verbose

The test code, if it failed, or if it was run in verbose mode, would
use the wrong variable for its loop.  Patch from rubiate uploaded to
19999.
---

diff --git a/src/test/test_addr.c b/src/test/test_addr.c
index c8a9e6d384..49e248014f 100644
--- a/src/test/test_addr.c
+++ b/src/test/test_addr.c
@@ -85,8 +85,8 @@ test_addr_basic(void *arg)
     char *, "%s",                                                \
     { char *cp;                                                  \
       cp = print_ = tor_malloc(64);                              \
-      for (int ii_=0;i<16;++i) {                                 \
-        tor_snprintf(cp, 3,"%02x", (unsigned)value_->s6_addr[i]);\
+      for (int ii_=0;ii_<16;++ii_) {                             \
+        tor_snprintf(cp, 3,"%02x", (unsigned)value_->s6_addr[ii_]);     \
         cp += 2;                                                 \
         if (ii_ != 15) *cp++ = ':';                              \
       }                                                          \