From: Arran Cudbard-Bell Date: Tue, 20 Apr 2021 13:34:30 +0000 (-0500) Subject: Just remove the damn assert. The rest of the code doesn't care about integer overflo... X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e23ad652c09f280a8f1c2cd989d327f11af11d6;p=thirdparty%2Ffreeradius-server.git Just remove the damn assert. The rest of the code doesn't care about integer overflow, it'll just stop the advance. --- diff --git a/src/lib/util/dbuff.h b/src/lib/util/dbuff.h index e743c5a25d4..f5986108933 100644 --- a/src/lib/util/dbuff.h +++ b/src/lib/util/dbuff.h @@ -952,7 +952,7 @@ _fr_dbuff_set(\ unsigned int : (size_t)(_len), \ unsigned long : (size_t)(_len), \ unsigned long long : (size_t)(_len), \ - int : (fr_cond_assert(((int)(_len)) >= 0) ? (size_t)(_len) : 0) \ + int : (size_t)(_len) \ )))) /** Advance the 'current' position in dbuff or marker by _len bytes returning if _len is out of range