From: William A. Rowe Jr <wrowe@apache.org>
Date: Mon, 6 Jun 2016 15:08:01 +0000 (+0000)
Subject: Showstopper to patch adoption, along with a more general objection
X-Git-Tag: 2.4.21~85
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e38f270e9051805334c79d70ea9293be5d5830f;p=thirdparty%2Fapache%2Fhttpd.git

Showstopper to patch adoption, along with a more general objection

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1747027 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index 9da200974dd..7dcde7984da 100644
--- a/STATUS
+++ b/STATUS
@@ -203,7 +203,20 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      2.4.x patch: http://home.apache.org/~jailletc36/apr_cstr_casecmp_v2.diff
      jailletc36: v2: update as per discussion on dev@. Do not mix ap_ and apr_
                  namespaces + tweak DOXYGEN comments.
-     +1: jailletc36, icing 
+     +1: jailletc36, icing
+     -0: wrowe [Prefer that we pre-@deprecate this API and encourage users
+                to adopt the apr_ convention, reversing the #defines, being
+                ready for the httpd 2.next minor release.]
+     -1: wrowe [Notes this patch creates binary incompatible versions of httpd
+                with this change; there must be #else stubs in util.c sources
+                compiled against APR 1.6+ for binary compatibility, even if
+                these are simply;
+                AP_DECLARE(int) ap_cstr_casecmpn(const char *s1,
+                                                 const char *s2, apr_size_t n)
+                {
+                    return apr_cstr_casecmpn(s1, s2, n);
+                }
+               ]
 
   *) abs: Add OPENSSL_Applink in Visual Studio >= 2015 or abs fails with a no
      OPENSSL_Applink error. PR59630