From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sun, 4 Jan 2015 00:43:43 +0000 (-0500)
Subject: Quiet coverity
X-Git-Tag: release_3_0_7~362
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e42eb18ebb4e2f31f3160713d1b94bc220859df;p=thirdparty%2Ffreeradius-server.git

Quiet coverity
---

diff --git a/src/main/modcall.c b/src/main/modcall.c
index 00593c6adf6..62882fcdfa1 100644
--- a/src/main/modcall.c
+++ b/src/main/modcall.c
@@ -2051,7 +2051,13 @@ static modcallable *do_compile_modforeach(modcallable *parent,
 		return NULL;
 	}
 
-	if (vpt && (vpt->type != TMPL_TYPE_ATTR) && (vpt->type != TMPL_TYPE_LIST)) {
+	/*
+	 *	If we don't have a negative return code, we must have a vpt
+	 *	(mostly to quiet coverity).
+	 */
+	rad_assert(vpt);
+
+	if ((vpt->type != TMPL_TYPE_ATTR) && (vpt->type != TMPL_TYPE_LIST)) {
 		cf_log_err_cs(cs, "MUST use attribute or list reference in 'foreach'");
 		return NULL;
 	}