From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Wed, 13 Apr 2011 17:02:23 +0000 (-0600)
Subject: Explain why we do not implement Icp::StoreMapCleaner API (yet).
X-Git-Tag: take06~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e568cca491d7e46bf167d2567a5eb0976b96465;p=thirdparty%2Fsquid.git

Explain why we do not implement Icp::StoreMapCleaner API (yet).
---

diff --git a/src/fs/rock/RockDirMap.h b/src/fs/rock/RockDirMap.h
index cbba2f3773..0b642418bc 100644
--- a/src/fs/rock/RockDirMap.h
+++ b/src/fs/rock/RockDirMap.h
@@ -37,4 +37,13 @@ private:
 // We do not reuse struct _fileMap because we cannot control its size,
 // resulting in sfilenos that are pointing beyond the database.
 
+/* 
+ * Rock::DirMap does not implement Icp::StoreMapCleaner API because we want
+ * to avoid extra I/O necessary to mark the disk slot empty. We may create some
+ * stale responses if Squid quits, but should save a lot of I/O in the common
+ * cases. TODO: Consider cleaning on-disk slots on exit; always scheduling 
+ * but cancelling/merging cleanup I/O; scheduling cleanup I/O after a
+ * configurable delay; etc.
+ */
+
 #endif /* SQUID_FS_ROCK_DIR_MAP_H */