From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 6 Aug 2019 11:45:42 +0000 (+0200)
Subject: qemuDomainGetResctrlMonData: Switch to switch()
X-Git-Tag: v5.7.0-rc1~371
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e66f0669afb3b0f29ffd6bea9cc3e8e607a7a85;p=thirdparty%2Flibvirt.git

qemuDomainGetResctrlMonData: Switch to switch()

This way it is obvious when adding a new resource control type
that stats helper func needs to be updated too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 25b6653e38..5606639482 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -20743,10 +20743,14 @@ qemuDomainGetResctrlMonData(virQEMUDriverPtr driver,
 
     caps = virQEMUDriverGetCapabilities(driver, false);
 
-    if (tag == VIR_RESCTRL_MONITOR_TYPE_CACHE) {
+    switch (tag) {
+    case VIR_RESCTRL_MONITOR_TYPE_CACHE:
         if (caps->host.cache.monitor)
             features = caps->host.cache.monitor->features;
-    } else {
+        break;
+    case VIR_RESCTRL_MONITOR_TYPE_MEMBW:
+    case VIR_RESCTRL_MONITOR_TYPE_UNSUPPORT:
+    case VIR_RESCTRL_MONITOR_TYPE_LAST:
         virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
                        _("Unsupported resctrl monitor type"));
         return -1;