From: Ralph Boehme Date: Thu, 30 Aug 2018 13:57:33 +0000 (+0200) Subject: s3:smbd: add a comment stating that file_close_user() is redundant for SMB2 X-Git-Tag: samba-4.7.11~16 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e8298e565657feee4fedec9e029d51504b903d8;p=thirdparty%2Fsamba.git s3:smbd: add a comment stating that file_close_user() is redundant for SMB2 Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sat Sep 1 01:26:35 CEST 2018 on sn-devel-144 (cherry picked from commit 5d95f79f604d90c2646225a0f2470f05dd71e19e) --- diff --git a/source3/smbd/smbXsrv_session.c b/source3/smbd/smbXsrv_session.c index 7fe385c2047..5780b7956c9 100644 --- a/source3/smbd/smbXsrv_session.c +++ b/source3/smbd/smbXsrv_session.c @@ -1652,6 +1652,12 @@ NTSTATUS smbXsrv_session_logoff(struct smbXsrv_session *session) session->status = NT_STATUS_USER_SESSION_DELETED; if (session->compat) { + /* + * For SMB2 this is a bit redundant as files are also close + * below via smb2srv_tcon_disconnect_all() -> ... -> + * smbXsrv_tcon_disconnect() -> close_cnum() -> + * file_close_conn(). + */ file_close_user(sconn, session->compat->vuid); }