From: Frederic Lecaille <flecaille@haproxy.com>
Date: Wed, 27 May 2026 13:18:40 +0000 (+0200)
Subject: CLEANUP: qpack: fix copy-paste typo in value Huffman debug string
X-Git-Tag: v3.4.0~82
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e83b7cd0828d464e038606190eff62039e246b1;p=thirdparty%2Fhaproxy.git

CLEANUP: qpack: fix copy-paste typo in value Huffman debug string

In qpack_decode_fs(), when decoding a literal field line with a literal
value, the debug message mistakenly printed "[name huff ...]" instead of
"[value huff ...]" after a successful Huffman decoding of the value string.

This is a harmless copy-paste typo from the field name decoding block
just above, fix it to prevent confusion when debugging QPACK streams.

Should be easily backported to all versions to ease further modifications
into the QPACK code.
---

diff --git a/src/qpack-dec.c b/src/qpack-dec.c
index e6ecb6dbb..886a7f34b 100644
--- a/src/qpack-dec.c
+++ b/src/qpack-dec.c
@@ -462,7 +462,7 @@ int qpack_decode_fs(const unsigned char *raw, uint64_t len, struct buffer *tmp,
 					goto out;
 				}
 
-				qpack_debug_printf(stderr, " [name huff %d->%d '%s']", (int)length, (int)nlen, trash);
+				qpack_debug_printf(stderr, " [value huff %d->%d '%s']", (int)length, (int)nlen, trash);
 				/* makes an ist from tmp storage */
 				b_add(tmp, nlen);
 				value = ist2(trash, nlen);