From: Volker Lendecke <vl@samba.org>
Date: Sat, 13 Sep 2025 09:50:24 +0000 (+0200)
Subject: smbd: Remove a temp variable used only once
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e86378d407a108c331bd28db3394f1dcac6e23d;p=thirdparty%2Fsamba.git

smbd: Remove a temp variable used only once

We use talloc_tos() as function argument in a lot of places already.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index 6f488812463..6e8da40794d 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -4056,7 +4056,6 @@ static NTSTATUS smb_info_set_ea(connection_struct *conn,
 				struct smb_filename *smb_fname)
 {
 	struct ea_list *ea_list = NULL;
-	TALLOC_CTX *ctx = NULL;
 	NTSTATUS status = NT_STATUS_OK;
 
 	if (total_data < 10) {
@@ -4078,8 +4077,7 @@ static NTSTATUS smb_info_set_ea(connection_struct *conn,
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 
-	ctx = talloc_tos();
-	ea_list = read_ea_list(ctx, pdata + 4, total_data - 4);
+	ea_list = read_ea_list(talloc_tos() , pdata + 4, total_data - 4);
 	if (!ea_list) {
 		return NT_STATUS_INVALID_PARAMETER;
 	}