From: Volker Lendecke <vl@samba.org>
Date: Wed, 8 Aug 2018 08:14:26 +0000 (+0200)
Subject: libsmb: Fix CID 1438243 Unchecked return value
X-Git-Tag: ldb-1.3.6~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0eaf84a4f5c313776c6feab2968f241b5ce55a91;p=thirdparty%2Fsamba.git

libsmb: Fix CID 1438243 Unchecked return value

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug  8 23:10:22 CEST 2018 on sn-devel-144
---

diff --git a/source3/libsmb/cliquota.c b/source3/libsmb/cliquota.c
index 8efd2bbe38a..52f98eb9e8f 100644
--- a/source3/libsmb/cliquota.c
+++ b/source3/libsmb/cliquota.c
@@ -649,7 +649,14 @@ NTSTATUS fill_quota_buffer(TALLOC_CTX *mem_ctx,
 		/* pidl will align to 8 bytes due to 8 byte members*/
 		/* Remember how much align padding we've used. */
 		padding = qndr->offset;
-		ndr_push_align(qndr, 8);
+
+		err = ndr_push_align(qndr, 8);
+		if (!NDR_ERR_CODE_IS_SUCCESS(err)) {
+			DBG_DEBUG("ndr_push_align returned %s\n",
+				  ndr_map_error2string(err));
+			return ndr_map_error2ntstatus(err);
+		}
+
 		padding = qndr->offset - padding;
 
 		/*