From: James Jones Date: Thu, 8 Feb 2024 21:31:33 +0000 (-0600) Subject: Annotate the other missing_lock in connection_check() (CID #1551702) X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ec8620549a6b04a146c12f95c59d9f063ed4ae2;p=thirdparty%2Ffreeradius-server.git Annotate the other missing_lock in connection_check() (CID #1551702) As with CID 1551700, Coverity doesn't know that all callers of connection_check() have locked pool->mutex, so we need to annotate the later reference to pool->pending_window. --- diff --git a/src/lib/server/pool.c b/src/lib/server/pool.c index 7f58b949ec0..a2a3bf4d2ee 100644 --- a/src/lib/server/pool.c +++ b/src/lib/server/pool.c @@ -774,7 +774,10 @@ static int connection_check(fr_pool_t *pool, request_t *request) if (spare < pool->spare) { /* * Don't open too many pending connections. + * Again, coverity doesn't realize all callers have the lock, + * so we must annotate here as well. */ + /* coverity[missing_lock] */ if (pool->state.pending >= pool->pending_window) goto manage_connections; /*