From: Štěpán Balážik <stepan.balazik@nic.cz>
Date: Thu, 10 Sep 2020 11:33:53 +0000 (+0200)
Subject: selection: don't query asynchronously, as it creates problems
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0edbf64d282e66e47bbcef0b96f734345d6614d9;p=thirdparty%2Fknot-resolver.git

selection: don't query asynchronously, as it creates problems

I can't see a simple way to prevent cycles.
Also, there were some weird memory leaks caused by it.
---

diff --git a/lib/selection_iter.c b/lib/selection_iter.c
index 5628f2549..9ec0f8e7d 100644
--- a/lib/selection_iter.c
+++ b/lib/selection_iter.c
@@ -187,11 +187,6 @@ void iter_choose_transport(struct kr_query *qry, struct kr_transport **transport
 
 	trie_it_free(it);
 
-	if (to_resolve) {
-		qry->request->selection_context.async_ns_resolution(unresolved_names[0], KNOT_RRTYPE_AAAA);
-		qry->request->selection_context.async_ns_resolution(unresolved_names[0], KNOT_RRTYPE_A);
-	}
-
 	if (valid_addresses || to_resolve) {
 		bool tcp = qry->flags.TCP | qry->server_selection.truncated;
 		*transport = choose_transport(choices, valid_addresses, unresolved_names, to_resolve, qry->server_selection.timeouts, mempool, tcp, NULL);