From: Andreas Schneider <asn@samba.org>
Date: Tue, 4 May 2021 09:08:28 +0000 (+0200)
Subject: s3:passdb: Check return code of cli_credentials_set_conf()
X-Git-Tag: tevent-0.11.0~146
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f13044634d67e717e3a7b3fec561273ff3d1f73;p=thirdparty%2Fsamba.git

s3:passdb: Check return code of cli_credentials_set_conf()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/passdb/passdb.c b/source3/passdb/passdb.c
index 73fcb3da308..068c5a5ea70 100644
--- a/source3/passdb/passdb.c
+++ b/source3/passdb/passdb.c
@@ -2590,7 +2590,11 @@ NTSTATUS pdb_get_trust_credentials(const char *netbios_domain,
 			goto fail;
 		}
 
-		cli_credentials_set_conf(creds, lp_ctx);
+		ok = cli_credentials_set_conf(creds, lp_ctx);
+		if (!ok) {
+			status = NT_STATUS_INTERNAL_ERROR;
+			goto fail;
+		}
 
 		ok = cli_credentials_set_domain(creds, netbios_domain, CRED_SPECIFIED);
 		if (!ok) {
@@ -2662,7 +2666,11 @@ NTSTATUS pdb_get_trust_credentials(const char *netbios_domain,
 		goto fail;
 	}
 
-	cli_credentials_set_conf(creds, lp_ctx);
+	ok = cli_credentials_set_conf(creds, lp_ctx);
+	if (!ok) {
+		status = NT_STATUS_INTERNAL_ERROR;
+		goto fail;
+	}
 
 	cli_credentials_set_secure_channel_type(creds, channel);
 	cli_credentials_set_password_last_changed_time(creds, last_set_time);