From: Jouni Malinen <j@w1.fi>
Date: Sat, 6 Mar 2021 22:54:36 +0000 (+0200)
Subject: More specific set_freq_params debug prints for 80/80+80 MHz errors
X-Git-Tag: hostap_2_10~467
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f37b8142b8423b63a3ae8a8744c50bb7f638c7a;p=thirdparty%2Fhostap.git

More specific set_freq_params debug prints for 80/80+80 MHz errors

It is more convenient to see the exact error in the debug log instead of
getting noted that something was invalid.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/common/hw_features_common.c b/src/common/hw_features_common.c
index b8b886fa1..ad2aebfef 100644
--- a/src/common/hw_features_common.c
+++ b/src/common/hw_features_common.c
@@ -572,13 +572,19 @@ int hostapd_set_freq_params(struct hostapd_freq_params *data,
 		/* fall through */
 	case CHANWIDTH_80MHZ:
 		data->bandwidth = 80;
-		if ((oper_chwidth == CHANWIDTH_80MHZ &&
-		     center_segment1) ||
-		    (oper_chwidth == CHANWIDTH_80P80MHZ &&
-		     !center_segment1) ||
-		    !sec_channel_offset) {
+		if (!sec_channel_offset) {
+			wpa_printf(MSG_ERROR,
+				   "80/80+80 MHz: no second channel offset");
+			return -1;
+		}
+		if (oper_chwidth == CHANWIDTH_80MHZ && center_segment1) {
+			wpa_printf(MSG_ERROR,
+				   "80 MHz: center segment 1 configured");
+			return -1;
+		}
+		if (oper_chwidth == CHANWIDTH_80P80MHZ && !center_segment1) {
 			wpa_printf(MSG_ERROR,
-				   "80/80+80 MHz: center segment 1 wrong or no second channel offset");
+				   "80+80 MHz: center segment 1 not configured");
 			return -1;
 		}
 		if (!center_segment0) {