From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Wed, 29 Aug 2012 13:44:05 +0000 (+0200)
Subject: build: add an explanatory comment
X-Git-Tag: v8.20~151
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f54e9761faf6a9c2bb3c7d1c415eea5d50985ae;p=thirdparty%2Fcoreutils.git

build: add an explanatory comment

* man/Makefile.am (EXTRA_DIST): Describe portability issues of the
idiom we now use.  Reformat the definition a little while at it.
---

diff --git a/man/Makefile.am b/man/Makefile.am
index 8e9df082b3..44eb3105fc 100644
--- a/man/Makefile.am
+++ b/man/Makefile.am
@@ -19,10 +19,19 @@ dist_man1_MANS = $(MAN)
 
 man_aux = $(dist_man1_MANS:.1=.x)
 
-EXTRA_DIST = $(man_aux) $(NO_INSTALL_PROGS_DEFAULT:%=%.x) help2man \
-	$(NO_INSTALL_PROGS_DEFAULT:%=%.1)
+EXTRA_DIST = $(man_aux) help2man
 MAINTAINERCLEANFILES = $(dist_man1_MANS)
 
+# The "$(VAR:%=%.x)" idiom is not portable according to POSIX, but in
+# practice it works with several make implementation (GNU, BSD, CCS make
+# from Solaris 10, Sun distributed make).  In addition, since only
+# maintainers are expected to build release tarballs (and they should
+# use GNU make when doing so), it's not big deal if this won't work with
+# some dumber make implementation.
+EXTRA_DIST += \
+  $(NO_INSTALL_PROGS_DEFAULT:%=%.x) \
+  $(NO_INSTALL_PROGS_DEFAULT:%=%.1)
+
 # Depend on ../.version to get version number changes.
 common_dep = ../.version