From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Thu, 6 Dec 2018 16:08:29 +0000 (+0100)
Subject: Skip server oom wildcard test on Windows to avoid firewall exception request
X-Git-Tag: dbus-1.13.10~46^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f5f95ab6eda8363b272285264cb8e07e3f8a1f1;p=thirdparty%2Fdbus.git

Skip server oom wildcard test on Windows to avoid firewall exception request

After starting the test on Windows 10, whether the local user is an
administrator or not, a dialog box appears with a warning that some
features of the app have been blocked by the firewall and prompts for
credentials for an administrator account while the test continues to
run and pass.

If this request is aborted, the dialog disappears; no restrictions are
visible for the test case. When the test is restarted, the dialog is also
no longer displayed.

In the firewall configuration you can then see that test-server-oom.exe
has been added (but not enabled) for public networks, although no
confirmation has been received from an administrator account.
---

diff --git a/test/internals/server-oom.c b/test/internals/server-oom.c
index 605566c89..dc3127fa5 100644
--- a/test/internals/server-oom.c
+++ b/test/internals/server-oom.c
@@ -46,6 +46,15 @@ test_new_server (void        *user_data,
   DBusServer *server = NULL;
   dbus_bool_t result = FALSE;
 
+#ifdef DBUS_WIN
+  if (strstr (listen_address, "bind=*") != NULL)
+    {
+      g_test_skip ("bind=* not tested on Windows to avoid a firewall-exception request (dbus#64)");
+      result = TRUE;
+      goto out;
+    }
+#endif
+
   server = dbus_server_listen (listen_address, &error);
 
   if (server == NULL)