From: Michal Nowak Date: Mon, 11 May 2026 17:19:53 +0000 (+0200) Subject: Pass -r option to respdiff.sh X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f63c1571807eb8762d3893d3a24299dd0185aab;p=thirdparty%2Fbind9.git Pass -r option to respdiff.sh Tell respdiff.sh where to find the respdiff Python tools (msgdiff.py, diffsum.py, ...) so the in-tree copy from bind9-qa is used. Assisted-by: Claude:claude-opus-4-7 (cherry picked from commit 4f410ee1e6b7f5a8cceb3331aa5be3dc74680aee) --- diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 84aae244720..7297e6aeeea 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -2262,7 +2262,7 @@ respdiff: CFLAGS: "${CFLAGS_COMMON} -Og" MAX_DISAGREEMENTS_PERCENTAGE: "0.3" script: - - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" + - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" -r "${PWD}/respdiff" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" - cd ../.. && make clean >/dev/null 2>&1 respdiff:asan: @@ -2275,7 +2275,7 @@ respdiff:asan: EXTRA_CONFIGURE: "--disable-dnsrps --without-jemalloc" MAX_DISAGREEMENTS_PERCENTAGE: "0.3" script: - - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" + - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" -r "${PWD}/respdiff" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" - cd ../.. && make clean >/dev/null 2>&1 respdiff:tsan: @@ -2291,7 +2291,7 @@ respdiff:tsan: MAX_DISAGREEMENTS_PERCENTAGE: "0.3" TSAN_OPTIONS: "${TSAN_OPTIONS_DEBIAN}" script: - - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" + - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" -r "${PWD}/respdiff" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" - cd ../.. && make clean >/dev/null 2>&1 after_script: - *parse_tsan @@ -2304,7 +2304,7 @@ respdiff-third-party: CFLAGS: "${CFLAGS_COMMON} -Og" MAX_DISAGREEMENTS_PERCENTAGE: "0.4" script: - - bash respdiff.sh -s third_party -q "${PWD}/100k_mixed.txt" -c 1 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" + - bash respdiff.sh -s third_party -q "${PWD}/100k_mixed.txt" -c 1 -w "${PWD}/rspworkdir" -r "${PWD}/respdiff" "${CI_PROJECT_DIR}" - cd ../.. && make clean >/dev/null 2>&1 .respdiff-recent-named: &respdiff_recent_named @@ -2323,7 +2323,7 @@ respdiff-third-party: - *configure - make -j${BUILD_PARALLEL_JOBS:-1} V=1 - cd "$CI_PROJECT_DIR"/bind9-qa/respdiff - - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" "${CI_PROJECT_DIR}/baseline-build/bin/named/named" + - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" -r "${PWD}/respdiff" "${CI_PROJECT_DIR}" "${CI_PROJECT_DIR}/baseline-build/bin/named/named" respdiff:recent-named: <<: *respdiff_recent_named