From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 14 Nov 2011 22:53:45 +0000 (-0500)
Subject: Detect failure from event_init() or event_base_new_with_config()
X-Git-Tag: tor-0.2.3.8-alpha~25^2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f6c02161793fa1022fe721ed9c1aac3538294b3;p=thirdparty%2Ftor.git

Detect failure from event_init() or event_base_new_with_config()
---

diff --git a/changes/bug4457 b/changes/bug4457
index d3d9eb3b40..fe7c95ff80 100644
--- a/changes/bug4457
+++ b/changes/bug4457
@@ -5,4 +5,5 @@
       bug 4457; workaround for Libevent versions 2.0.1-alpha through
       2.0.15-stable.
 
+    - Detect failure to initialize Libevent. Better detection for bug 4457.
 
diff --git a/src/common/compat_libevent.c b/src/common/compat_libevent.c
index 3e35e093e4..ddb2da68aa 100644
--- a/src/common/compat_libevent.c
+++ b/src/common/compat_libevent.c
@@ -179,6 +179,7 @@ tor_libevent_initialize(void)
 #ifdef HAVE_EVENT2_EVENT_H
   {
     struct event_config *cfg = event_config_new();
+    tor_assert(cfg);
 
     /* In 0.2.2, we don't use locking at all.  Telling Libevent not to try to
      * turn it on can avoid a needless socketpair() attempt.
@@ -193,6 +194,11 @@ tor_libevent_initialize(void)
   the_event_base = event_init();
 #endif
 
+  if (!the_event_base) {
+    log_err(LD_GENERAL, "Unable to initialize Libevent: cannot continue.");
+    exit(1);
+  }
+
 #if defined(HAVE_EVENT_GET_VERSION) && defined(HAVE_EVENT_GET_METHOD)
   /* Making this a NOTICE for now so we can link bugs to a libevent versions
    * or methods better. */