From: Rainer Jung Date: Sun, 15 Oct 2017 11:31:58 +0000 (+0000) Subject: Vote, comment. X-Git-Tag: 2.4.29~24 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f709aa818ca21f8159bcf92a231109f42bcdd57;p=thirdparty%2Fapache%2Fhttpd.git Vote, comment. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1812217 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/STATUS b/STATUS index 7da5c532d5b..c4b0d57d004 100644 --- a/STATUS +++ b/STATUS @@ -214,9 +214,24 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: trunk patch: http://svn.apache.org/r1810448 http://svn.apache.org/r1810998 2.4.x patch: svn merge -c 1810448,1810998 ^/httpd/httpd/trunk . - +1: jim, wrowe + +1: jim, wrowe, rjung [This seems to fit into the mold of per-platform quirks which we process in CTR flow, adding my +1 to note that the patch looks sane.] + rjung: The following two comments are not meant to block applying that change. + - A possible enhancement would be to detect the problem, e.g. + using AC_CHECK_LIB for a test that should always succeed and + if it fails, try again with "-Wno-error=strict-prototypes". + - Another more far reaching enhancement would be to add + "-Wno-error=strict-prototypes" only during configure but not + later when we do the actual build in order to still detect missing + prototypes then. Since configure does not seem to have the + concept of settings only applied during configure run, we would + need to remember "-Wno-error=strict-prototypes" as a flag we just + added to make configure work. Then, right before configure + generates output files, we would strip any such flag from CFLAGS + to generate the correct build time CFLAGS. + Unfortunately things might get trickier when building apr/apu + in combination with httpd. PATCHES/ISSUES THAT ARE BEING WORKED