From: Eric Wong <e@80x24.org>
Date: Tue, 7 Mar 2023 09:54:15 +0000 (+0000)
Subject: test_common: run_script: drop special-case for -clone
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0fa19f1a4b6949808c311312e80d9d3a5010cc23;p=thirdparty%2Fpublic-inbox.git

test_common: run_script: drop special-case for -clone

`make check' and `make check-run' actually work fine with it,
and TMPDIR=/dev/shm prove -lvw t/clone-coderepo.t is 2-3x faster
---

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index fe7af452e..5807105ae 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -295,7 +295,6 @@ sub run_script ($;$$) {
 	my ($cmd, $env, $opt) = @_;
 	my ($key, @argv) = @$cmd;
 	my $run_mode = $ENV{TEST_RUN_MODE} // $opt->{run_mode} // 1;
-	$run_mode = 0 if $key eq '-clone'; # relies on SIGCHLD + waitpid(-1)
 	my $sub = $run_mode == 0 ? undef : key2sub($key);
 	my $fhref = [];
 	my $spawn_opt = {};