From: Mark Brown Date: Wed, 22 Apr 2026 20:34:05 +0000 (+0100) Subject: ASoC: ops: Log unknown controls in snd_soc_limit_volume() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0fa63c7ea9e1571f9da9fd4afda22361966b3236;p=thirdparty%2Flinux.git ASoC: ops: Log unknown controls in snd_soc_limit_volume() When we fail to look up the control name in snd_soc_limit_volume() we don't log anything, the error code isn't particularly descriptive and checking the return value of the function at all is a bit erratic among the callers. Since there is no reason why anyone should ever be attempting to limit the volume of a nonexistant control add a log message in the core to improve usability. Link: https://patch.msgid.link/20260422-asoc-limit-volume-error-v2-1-2e2ced321229@kernel.org Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c index bbf277670718e..c935571d43e9d 100644 --- a/sound/soc/soc-ops.c +++ b/sound/soc/soc-ops.c @@ -461,6 +461,10 @@ int snd_soc_limit_volume(struct snd_soc_card *card, const char *name, int max) mc->platform_max = max; ret = snd_soc_clip_to_platform_max(kctl); } + } else { + /* Some cards blindly add limits for multiple variants. */ + dev_dbg(card->dev, "Volume limit for unknown control '%s'\n", + name); } return ret;