From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 23 Feb 2021 13:09:55 +0000 (+0100)
Subject: rec: Convert the warning about storing in raw form to a comment
X-Git-Tag: dnsdist-1.6.0-alpha2~12^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0fb08e4f7ac8b3ff29c082caa93a22f5284cf006;p=thirdparty%2Fpdns.git

rec: Convert the warning about storing in raw form to a comment
---

diff --git a/pdns/recursordist/aggressive_nsec.cc b/pdns/recursordist/aggressive_nsec.cc
index 3e47588bc8..cb08064339 100644
--- a/pdns/recursordist/aggressive_nsec.cc
+++ b/pdns/recursordist/aggressive_nsec.cc
@@ -289,7 +289,8 @@ void AggressiveNSECCache::insertNSEC(const DNSName& zone, const DNSName& owner,
         return;
       }
 
-#warning Ponder storing everything in raw form, without the zone instead. It still needs to be a DNSName for NSEC, though
+      // XXX: Ponder storing everything in raw form, without the zone instead. It still needs to be a DNSName for NSEC, though,
+      // but doing the conversion on cache hits only might be faster
       next = DNSName(toBase32Hex(content->d_nexthash)) + zone;
 
       if (entry->d_iterations != content->d_iterations || entry->d_salt != content->d_salt) {