From: Roger Dingledine <arma@torproject.org>
Date: Tue, 23 Sep 2008 08:54:03 +0000 (+0000)
Subject: identical error strings in different contexts bad
X-Git-Tag: tor-0.2.1.6-alpha~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0fc0d5266ccb91139616bbe5b16a793c8d75392f;p=thirdparty%2Ftor.git

identical error strings in different contexts bad


svn:r16937
---

diff --git a/src/or/directory.c b/src/or/directory.c
index 80e0ff78e5..e5f50ae14b 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -3024,11 +3024,11 @@ directory_handle_command_post(dir_connection_t *conn, const char *headers,
       case -1:
         log_warn(LD_REND, "Rejected v2 rend descriptor (length %d) from %s.",
                  (int)body_len, conn->_base.address);
-        write_http_status_line(conn, 400, "Invalid service descriptor "
-                                          "rejected");
+        write_http_status_line(conn, 400,
+                               "Invalid v2 service descriptor rejected");
         break;
       default:
-        write_http_status_line(conn, 200, "Service descriptor stored");
+        write_http_status_line(conn, 200, "Service descriptor (v2) stored");
         log_info(LD_REND, "Handled v2 rendezvous descriptor post: accepted");
     }
     goto done;
@@ -3082,9 +3082,10 @@ directory_handle_command_post(dir_connection_t *conn, const char *headers,
       log_fn(LOG_PROTOCOL_WARN, LD_DIRSERV,
              "Rejected rend descriptor (length %d) from %s.",
              (int)body_len, conn->_base.address);
-      write_http_status_line(conn, 400, "Invalid service descriptor rejected");
+      write_http_status_line(conn, 400,
+                             "Invalid v1 service descriptor rejected");
     } else {
-      write_http_status_line(conn, 200, "Service descriptor stored");
+      write_http_status_line(conn, 200, "Service descriptor (v1) stored");
     }
     goto done;
   }