From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Wed, 6 Jul 2022 20:12:28 +0000 (-0600)
Subject: wrapper.c: fix string non-termination warning
X-Git-Tag: v3.0~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0fd476b6a6f309ccd3b0c473c844a27e7620cddd;p=thirdparty%2Flibcgroup.git

wrapper.c: fix string non-termination warning

Fix non-terminated string warning, reported by Coverity tool:

CID 258266 (#1 of 1): String not null-terminated (STRING_NULL).
string_null: Passing unterminated string con to strtok, which expects a
null-terminated string.

Fix the warning in create_cgroup_from_name_value_pairs(), by adding
'\0'.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/wrapper.c b/src/wrapper.c
index 933075df..c3d766d2 100644
--- a/src/wrapper.c
+++ b/src/wrapper.c
@@ -687,6 +687,8 @@ struct cgroup *create_cgroup_from_name_value_pairs(const char *name,
 		}
 
 		strncpy(con, name_value[i].name, FILENAME_MAX - 1);
+		con[FILENAME_MAX - 1] = '\0';
+
 		strtok(con, ".");
 
 		/*