From: Victor Julien <vjulien@oisf.net>
Date: Tue, 20 Dec 2022 09:58:27 +0000 (+0100)
Subject: netmap/runmode: minor code cleanup
X-Git-Tag: suricata-7.0.0-rc1~203
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ff88c0315494ce304e3dc32e12d7ab95912c579;p=thirdparty%2Fsuricata.git

netmap/runmode: minor code cleanup
---

diff --git a/src/runmode-netmap.c b/src/runmode-netmap.c
index 351000951f..30e726f557 100644
--- a/src/runmode-netmap.c
+++ b/src/runmode-netmap.c
@@ -410,29 +410,30 @@ static int NetmapRunModeInit(NetmapRunMode_t runmode)
     const char *live_dev = NULL;
     (void)ConfGet("netmap.live-interface", &live_dev);
 
+    const char *runmode_str = "unknown";
     int ret;
     switch (runmode) {
         case NETMAP_AUTOFP:
+            runmode_str = "autofp";
             ret = RunModeSetLiveCaptureAutoFp(ParseNetmapConfig, NetmapConfigGeThreadsCount,
                     "ReceiveNetmap", "DecodeNetmap", thread_name_autofp, live_dev);
             break;
         case NETMAP_WORKERS:
+            runmode_str = "workers";
             ret = RunModeSetLiveCaptureWorkers(ParseNetmapConfig, NetmapConfigGeThreadsCount,
                     "ReceiveNetmap", "DecodeNetmap", thread_name_workers, live_dev);
             break;
         case NETMAP_SINGLE:
+            runmode_str = "single";
             ret = RunModeSetLiveCaptureSingle(ParseNetmapConfig, NetmapConfigGeThreadsCount,
                     "ReceiveNetmap", "DecodeNetmap", thread_name_single, live_dev);
             break;
     }
     if (ret != 0) {
-        FatalError("Unable to start runmode %s", runmode == NETMAP_AUTOFP    ? "autofp"
-                                                 : runmode == NETMAP_WORKERS ? "workers"
-                                                                             : "single");
+        FatalError("Unable to start runmode %s", runmode_str);
     }
 
-    SCLogDebug("%s initialized",
-            runmode == NETMAP_AUTOFP ? "autofp" : runmode == NETMAP_WORKERS ? "workers" : "single");
+    SCLogDebug("%s initialized", runmode_str);
 
     SCReturnInt(0);
 }