From: jocuri%softhome.net <> Date: Mon, 17 Jan 2005 04:43:21 +0000 (+0000) Subject: Patch for bug 254351: Patch to add a cookiedomain parameter; patch by Eric Haszlakiew... X-Git-Tag: bugzilla-2.19.3~390 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ffaf78a472cfd6dd5a4b1da80b5dd50f2611647;p=thirdparty%2Fbugzilla.git Patch for bug 254351: Patch to add a cookiedomain parameter; patch by Eric Haszlakiewicz , r=kiko, a=myk. --- diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index ce0a8ab6c9..c4433cc62b 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -179,6 +179,10 @@ sub send_cookie { # Add the default path in unshift(@_, '-path' => Param('cookiepath')); + if (Param('cookiedomain')) + { + unshift(@_, '-domain' => Param('cookiedomain')); + } # Use CGI::Cookie directly, because CGI.pm's |cookie| method gives the # current value if there isn't a -value attribute, which happens when diff --git a/buglist.cgi b/buglist.cgi index 2c194d5a62..6df402781e 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -961,8 +961,6 @@ my $contenttype; my $disp = "inline"; if ($format->{'extension'} eq "html") { - my $cookiepath = Param("cookiepath"); - if ($order) { $cgi->send_cookie(-name => 'LASTORDER', -value => $order, diff --git a/defparams.pl b/defparams.pl index d97a090855..206e89e591 100644 --- a/defparams.pl +++ b/defparams.pl @@ -357,6 +357,17 @@ sub find_languages { checker => \&check_languages }, + { + name => 'cookiedomain', + desc => 'The domain for Bugzilla cookies. Normally blank. ' . + 'If your website is at "www.foo.com", setting this to ' . + '".foo.com" will also allow bar.foo.com to access ' . + 'Bugzilla cookies. This is useful if you have more than ' . + 'one hostname pointing at the same web server, and you ' . + 'want them to share the Bugzilla cookie.', + type => 't', + default => '' + }, { name => 'cookiepath', desc => 'Path, relative to your web document root, to which to restrict ' . diff --git a/post_bug.cgi b/post_bug.cgi index b51e24db51..3f2d32062f 100755 --- a/post_bug.cgi +++ b/post_bug.cgi @@ -84,7 +84,6 @@ if (!$product_id) { } # Set cookies -my $cookiepath = Param("cookiepath"); if (exists $::FORM{'product'}) { if (exists $::FORM{'version'}) { $cgi->send_cookie(-name => "VERSION-$product",