From: Frédéric Buclin Date: Sat, 1 Sep 2012 21:43:00 +0000 (+0200) Subject: Bug 787529: Use |use 5.10.1| everywhere X-Git-Tag: bugzilla-4.5.1~405 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1001cbba7b16ccc4611bbee0474264bb551d1ea5;p=thirdparty%2Fbugzilla.git Bug 787529: Use |use 5.10.1| everywhere r=wicked a=LpSolit --- diff --git a/Bugzilla.pm b/Bugzilla.pm index ccd3840674..f956f5a0ea 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -7,6 +7,7 @@ package Bugzilla; +use 5.10.1; use strict; # We want any compile errors to get to the browser, if possible. diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index d6c7e39240..1c524c24b3 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Attachment; +use 5.10.1; +use strict; + =head1 NAME Bugzilla::Attachment - Bugzilla attachment class. diff --git a/Bugzilla/Attachment/PatchReader.pm b/Bugzilla/Attachment/PatchReader.pm index e9cb189efa..4583dbd518 100644 --- a/Bugzilla/Attachment/PatchReader.pm +++ b/Bugzilla/Attachment/PatchReader.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Attachment::PatchReader; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::Attachment; use Bugzilla::Util; diff --git a/Bugzilla/Auth.pm b/Bugzilla/Auth.pm index 477dbffaa8..412edd5a1d 100644 --- a/Bugzilla/Auth.pm +++ b/Bugzilla/Auth.pm @@ -7,6 +7,7 @@ package Bugzilla::Auth; +use 5.10.1; use strict; use fields qw( _info_getter diff --git a/Bugzilla/Auth/Login.pm b/Bugzilla/Auth/Login.pm index 290cb42ffd..33d63a425c 100644 --- a/Bugzilla/Auth/Login.pm +++ b/Bugzilla/Auth/Login.pm @@ -7,6 +7,7 @@ package Bugzilla::Auth::Login; +use 5.10.1; use strict; use fields qw(); diff --git a/Bugzilla/Auth/Login/CGI.pm b/Bugzilla/Auth/Login/CGI.pm index 47ec556a70..a4fb3aea2e 100644 --- a/Bugzilla/Auth/Login/CGI.pm +++ b/Bugzilla/Auth/Login/CGI.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::CGI; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use constant user_can_create_account => 1; diff --git a/Bugzilla/Auth/Login/Cookie.pm b/Bugzilla/Auth/Login/Cookie.pm index 5d4c8279ce..1f6f83f5e5 100644 --- a/Bugzilla/Auth/Login/Cookie.pm +++ b/Bugzilla/Auth/Login/Cookie.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::Cookie; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Login/Env.pm b/Bugzilla/Auth/Login/Env.pm index 393ac600df..9b24c0edc1 100644 --- a/Bugzilla/Auth/Login/Env.pm +++ b/Bugzilla/Auth/Login/Env.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::Env; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Login/Stack.pm b/Bugzilla/Auth/Login/Stack.pm index 17a5855b63..ad5598576a 100644 --- a/Bugzilla/Auth/Login/Stack.pm +++ b/Bugzilla/Auth/Login/Stack.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::Stack; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use fields qw( _stack diff --git a/Bugzilla/Auth/Persist/Cookie.pm b/Bugzilla/Auth/Persist/Cookie.pm index ec212088d8..15a2d490e2 100644 --- a/Bugzilla/Auth/Persist/Cookie.pm +++ b/Bugzilla/Auth/Persist/Cookie.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Persist::Cookie; + +use 5.10.1; use strict; use fields qw(); diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm index ae256dd8c8..de8b4030d9 100644 --- a/Bugzilla/Auth/Verify.pm +++ b/Bugzilla/Auth/Verify.pm @@ -7,6 +7,7 @@ package Bugzilla::Auth::Verify; +use 5.10.1; use strict; use fields qw(); diff --git a/Bugzilla/Auth/Verify/DB.pm b/Bugzilla/Auth/Verify/DB.pm index 6ca04f2597..dc074b20ac 100644 --- a/Bugzilla/Auth/Verify/DB.pm +++ b/Bugzilla/Auth/Verify/DB.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::DB; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Verify/LDAP.pm b/Bugzilla/Auth/Verify/LDAP.pm index 5704c5848a..63e05ed457 100644 --- a/Bugzilla/Auth/Verify/LDAP.pm +++ b/Bugzilla/Auth/Verify/LDAP.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::LDAP; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use fields qw( ldap diff --git a/Bugzilla/Auth/Verify/RADIUS.pm b/Bugzilla/Auth/Verify/RADIUS.pm index d6c4db8e8b..9fecec77e8 100644 --- a/Bugzilla/Auth/Verify/RADIUS.pm +++ b/Bugzilla/Auth/Verify/RADIUS.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::RADIUS; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Verify/Stack.pm b/Bugzilla/Auth/Verify/Stack.pm index 0930d57ed7..52c449e22f 100644 --- a/Bugzilla/Auth/Verify/Stack.pm +++ b/Bugzilla/Auth/Verify/Stack.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::Stack; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use fields qw( _stack diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 2e9ed52e00..f47ed81c96 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -7,6 +7,7 @@ package Bugzilla::Bug; +use 5.10.1; use strict; use Bugzilla::Attachment; diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm index 764b223db6..2c1ab58855 100644 --- a/Bugzilla/BugMail.pm +++ b/Bugzilla/BugMail.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::BugMail; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::User; use Bugzilla::Constants; diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm index 8689e8a350..ec6675e909 100644 --- a/Bugzilla/BugUrl.pm +++ b/Bugzilla/BugUrl.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl; + +use 5.10.1; use strict; + use base qw(Bugzilla::Object); use Bugzilla::Util; diff --git a/Bugzilla/BugUrl/Bugzilla.pm b/Bugzilla/BugUrl/Bugzilla.pm index 4db37eb7f9..8e2f372268 100644 --- a/Bugzilla/BugUrl/Bugzilla.pm +++ b/Bugzilla/BugUrl/Bugzilla.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Bugzilla; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); use Bugzilla::Error; diff --git a/Bugzilla/BugUrl/Bugzilla/Local.pm b/Bugzilla/BugUrl/Bugzilla/Local.pm index 9631716ae2..360d5dd974 100644 --- a/Bugzilla/BugUrl/Bugzilla/Local.pm +++ b/Bugzilla/BugUrl/Bugzilla/Local.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Bugzilla::Local; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl::Bugzilla); use Bugzilla::Error; diff --git a/Bugzilla/BugUrl/Debian.pm b/Bugzilla/BugUrl/Debian.pm index 78397bdd94..f791a437ef 100644 --- a/Bugzilla/BugUrl/Debian.pm +++ b/Bugzilla/BugUrl/Debian.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Debian; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/GitHub.pm b/Bugzilla/BugUrl/GitHub.pm index 63be65bed8..1dc325c806 100644 --- a/Bugzilla/BugUrl/GitHub.pm +++ b/Bugzilla/BugUrl/GitHub.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::GitHub; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/Google.pm b/Bugzilla/BugUrl/Google.pm index 8b8638c7a0..809c92ccab 100644 --- a/Bugzilla/BugUrl/Google.pm +++ b/Bugzilla/BugUrl/Google.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Google; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/JIRA.pm b/Bugzilla/BugUrl/JIRA.pm index f5f7ee5fa9..d9614c4bdc 100644 --- a/Bugzilla/BugUrl/JIRA.pm +++ b/Bugzilla/BugUrl/JIRA.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::JIRA; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/Launchpad.pm b/Bugzilla/BugUrl/Launchpad.pm index 87fb71a5dc..f858f28951 100644 --- a/Bugzilla/BugUrl/Launchpad.pm +++ b/Bugzilla/BugUrl/Launchpad.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Launchpad; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/MantisBT.pm b/Bugzilla/BugUrl/MantisBT.pm index 3d49ede69e..d774eca109 100644 --- a/Bugzilla/BugUrl/MantisBT.pm +++ b/Bugzilla/BugUrl/MantisBT.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::MantisBT; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/SourceForge.pm b/Bugzilla/BugUrl/SourceForge.pm index 11cdd0ff18..ee9a3e7ca2 100644 --- a/Bugzilla/BugUrl/SourceForge.pm +++ b/Bugzilla/BugUrl/SourceForge.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::SourceForge; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/Trac.pm b/Bugzilla/BugUrl/Trac.pm index 8f6e9cd0e8..ddad281fee 100644 --- a/Bugzilla/BugUrl/Trac.pm +++ b/Bugzilla/BugUrl/Trac.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Trac; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index a68195f224..99851c21de 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::CGI; + +use 5.10.1; use strict; + use base qw(CGI); use Bugzilla::Constants; diff --git a/Bugzilla/Chart.pm b/Bugzilla/Chart.pm index 0a655769fb..d157457c24 100644 --- a/Bugzilla/Chart.pm +++ b/Bugzilla/Chart.pm @@ -5,8 +5,6 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - # This module represents a chart. # # Note that it is perfectly legal for the 'lines' member variable of this @@ -15,6 +13,9 @@ use strict; # the same points. package Bugzilla::Chart; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::Util; use Bugzilla::Series; diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm index 2b35a88391..67ba8b46f5 100644 --- a/Bugzilla/Classification.pm +++ b/Bugzilla/Classification.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Classification; +use 5.10.1; +use strict; + use Bugzilla::Constants; use Bugzilla::Field; use Bugzilla::Util; diff --git a/Bugzilla/Comment.pm b/Bugzilla/Comment.pm index 549753d2b0..7cf924893d 100644 --- a/Bugzilla/Comment.pm +++ b/Bugzilla/Comment.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Comment; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Attachment; diff --git a/Bugzilla/Component.pm b/Bugzilla/Component.pm index f189639468..b8321cbf92 100644 --- a/Bugzilla/Component.pm +++ b/Bugzilla/Component.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Component; + +use 5.10.1; use strict; + use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm index 150996e05d..f422de227b 100644 --- a/Bugzilla/Config.pm +++ b/Bugzilla/Config.pm @@ -7,6 +7,7 @@ package Bugzilla::Config; +use 5.10.1; use strict; use base qw(Exporter); diff --git a/Bugzilla/Config/Admin.pm b/Bugzilla/Config/Admin.pm index 7be3e54d11..811f7029e8 100644 --- a/Bugzilla/Config/Admin.pm +++ b/Bugzilla/Config/Admin.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Admin; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Advanced.pm b/Bugzilla/Config/Advanced.pm index fa5b7d249f..eec2816d26 100644 --- a/Bugzilla/Config/Advanced.pm +++ b/Bugzilla/Config/Advanced.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Config::Advanced; + +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Attachment.pm b/Bugzilla/Config/Attachment.pm index ba19f77823..f31e57254a 100644 --- a/Bugzilla/Config/Attachment.pm +++ b/Bugzilla/Config/Attachment.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Attachment; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Auth.pm b/Bugzilla/Config/Auth.pm index 19ba59b0c3..579f86ad8d 100644 --- a/Bugzilla/Config/Auth.pm +++ b/Bugzilla/Config/Auth.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Auth; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/BugChange.pm b/Bugzilla/Config/BugChange.pm index 68cfe5676e..53fc68d00c 100644 --- a/Bugzilla/Config/BugChange.pm +++ b/Bugzilla/Config/BugChange.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::BugChange; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/BugFields.pm b/Bugzilla/Config/BugFields.pm index 7ae9ae3552..e24f756618 100644 --- a/Bugzilla/Config/BugFields.pm +++ b/Bugzilla/Config/BugFields.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::BugFields; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Common.pm b/Bugzilla/Config/Common.pm index 0e3551d13f..32e8ba5697 100644 --- a/Bugzilla/Config/Common.pm +++ b/Bugzilla/Config/Common.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Common; +use 5.10.1; use strict; use Email::Address; diff --git a/Bugzilla/Config/Core.pm b/Bugzilla/Config/Core.pm index f2510d2b2c..faf86c5673 100644 --- a/Bugzilla/Config/Core.pm +++ b/Bugzilla/Config/Core.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Core; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/DependencyGraph.pm b/Bugzilla/Config/DependencyGraph.pm index cc61e35887..42f34e30e9 100644 --- a/Bugzilla/Config/DependencyGraph.pm +++ b/Bugzilla/Config/DependencyGraph.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::DependencyGraph; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/General.pm b/Bugzilla/Config/General.pm index 6e00b202a1..a401e98edd 100644 --- a/Bugzilla/Config/General.pm +++ b/Bugzilla/Config/General.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Config::General; + +use 5.10.1; use strict; + use Bugzilla::Config::Common; our $sortkey = 150; diff --git a/Bugzilla/Config/GroupSecurity.pm b/Bugzilla/Config/GroupSecurity.pm index 54f5935a61..d5f02f42da 100644 --- a/Bugzilla/Config/GroupSecurity.pm +++ b/Bugzilla/Config/GroupSecurity.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::GroupSecurity; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/LDAP.pm b/Bugzilla/Config/LDAP.pm index daa7f72bbf..4a46f40d2c 100644 --- a/Bugzilla/Config/LDAP.pm +++ b/Bugzilla/Config/LDAP.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::LDAP; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/MTA.pm b/Bugzilla/Config/MTA.pm index bf038cf493..a6ca366132 100644 --- a/Bugzilla/Config/MTA.pm +++ b/Bugzilla/Config/MTA.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::MTA; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/PatchViewer.pm b/Bugzilla/Config/PatchViewer.pm index 08e8028f31..2005e4c4a1 100644 --- a/Bugzilla/Config/PatchViewer.pm +++ b/Bugzilla/Config/PatchViewer.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::PatchViewer; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Query.pm b/Bugzilla/Config/Query.pm index fe54d67abd..e1287386b7 100644 --- a/Bugzilla/Config/Query.pm +++ b/Bugzilla/Config/Query.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Query; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/RADIUS.pm b/Bugzilla/Config/RADIUS.pm index 312be1ded6..17fbdd7ddf 100644 --- a/Bugzilla/Config/RADIUS.pm +++ b/Bugzilla/Config/RADIUS.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::RADIUS; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/ShadowDB.pm b/Bugzilla/Config/ShadowDB.pm index c0ff590960..65c572980f 100644 --- a/Bugzilla/Config/ShadowDB.pm +++ b/Bugzilla/Config/ShadowDB.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::ShadowDB; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/UserMatch.pm b/Bugzilla/Config/UserMatch.pm index 5b98a25eac..53fb5136fb 100644 --- a/Bugzilla/Config/UserMatch.pm +++ b/Bugzilla/Config/UserMatch.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::UserMatch; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Constants.pm b/Bugzilla/Constants.pm index c02558faa9..1ec9218353 100644 --- a/Bugzilla/Constants.pm +++ b/Bugzilla/Constants.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Constants; + +use 5.10.1; use strict; + use base qw(Exporter); # For bz_locations diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm index 7d289aaa11..7756ff53b7 100644 --- a/Bugzilla/DB.pm +++ b/Bugzilla/DB.pm @@ -7,6 +7,7 @@ package Bugzilla::DB; +use 5.10.1; use strict; use DBI; diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm index 90bacc02a3..9cfa834625 100644 --- a/Bugzilla/DB/Mysql.pm +++ b/Bugzilla/DB/Mysql.pm @@ -20,7 +20,10 @@ For interface details see L and L. =cut package Bugzilla::DB::Mysql; + +use 5.10.1; use strict; + use base qw(Bugzilla::DB); use Bugzilla::Constants; diff --git a/Bugzilla/DB/Oracle.pm b/Bugzilla/DB/Oracle.pm index f5045b2c71..3f7bc2b872 100644 --- a/Bugzilla/DB/Oracle.pm +++ b/Bugzilla/DB/Oracle.pm @@ -20,7 +20,10 @@ For interface details see L and L. =cut package Bugzilla::DB::Oracle; + +use 5.10.1; use strict; + use base qw(Bugzilla::DB); use DBD::Oracle; @@ -706,6 +709,10 @@ sub _get_create_trigger_ddl { ############################################################################ package Bugzilla::DB::Oracle::st; + +use 5.10.1; +use strict; + use base qw(DBI::st); sub fetchrow_arrayref { diff --git a/Bugzilla/DB/Pg.pm b/Bugzilla/DB/Pg.pm index c794bdcc52..80bfb4f5f7 100644 --- a/Bugzilla/DB/Pg.pm +++ b/Bugzilla/DB/Pg.pm @@ -21,6 +21,7 @@ For interface details see L and L. package Bugzilla::DB::Pg; +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm index eabee07c3c..eb46aa80fd 100644 --- a/Bugzilla/DB/Schema.pm +++ b/Bugzilla/DB/Schema.pm @@ -15,7 +15,9 @@ package Bugzilla::DB::Schema; # ########################################################################### +use 5.10.1; use strict; + use Bugzilla::Error; use Bugzilla::Hook; use Bugzilla::Util; diff --git a/Bugzilla/DB/Schema/Mysql.pm b/Bugzilla/DB/Schema/Mysql.pm index 020549a893..8b06dc42ba 100644 --- a/Bugzilla/DB/Schema/Mysql.pm +++ b/Bugzilla/DB/Schema/Mysql.pm @@ -13,7 +13,9 @@ package Bugzilla::DB::Schema::Mysql; # ############################################################################### +use 5.10.1; use strict; + use Bugzilla::Error; use base qw(Bugzilla::DB::Schema); diff --git a/Bugzilla/DB/Schema/Oracle.pm b/Bugzilla/DB/Schema/Oracle.pm index 381906d2e0..26141c5f49 100644 --- a/Bugzilla/DB/Schema/Oracle.pm +++ b/Bugzilla/DB/Schema/Oracle.pm @@ -13,6 +13,7 @@ package Bugzilla::DB::Schema::Oracle; # ############################################################################### +use 5.10.1; use strict; use base qw(Bugzilla::DB::Schema); diff --git a/Bugzilla/DB/Schema/Pg.pm b/Bugzilla/DB/Schema/Pg.pm index 3dc0fe85e8..8dcd09b896 100644 --- a/Bugzilla/DB/Schema/Pg.pm +++ b/Bugzilla/DB/Schema/Pg.pm @@ -13,7 +13,9 @@ package Bugzilla::DB::Schema::Pg; # ############################################################################### +use 5.10.1; use strict; + use base qw(Bugzilla::DB::Schema); use Storable qw(dclone); diff --git a/Bugzilla/DB/Schema/Sqlite.pm b/Bugzilla/DB/Schema/Sqlite.pm index 4cfc2b0525..780764a699 100644 --- a/Bugzilla/DB/Schema/Sqlite.pm +++ b/Bugzilla/DB/Schema/Sqlite.pm @@ -5,8 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; package Bugzilla::DB::Schema::Sqlite; + +use 5.10.1; +use strict; + use base qw(Bugzilla::DB::Schema); use Bugzilla::Error; diff --git a/Bugzilla/DB/Sqlite.pm b/Bugzilla/DB/Sqlite.pm index f27ad71431..5564e21df4 100644 --- a/Bugzilla/DB/Sqlite.pm +++ b/Bugzilla/DB/Sqlite.pm @@ -5,8 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; package Bugzilla::DB::Sqlite; + +use 5.10.1; +use strict; + use base qw(Bugzilla::DB); use Bugzilla::Constants; diff --git a/Bugzilla/Error.pm b/Bugzilla/Error.pm index e1df5ddbb1..03fc8d6428 100644 --- a/Bugzilla/Error.pm +++ b/Bugzilla/Error.pm @@ -7,7 +7,9 @@ package Bugzilla::Error; +use 5.10.1; use strict; + use base qw(Exporter); @Bugzilla::Error::EXPORT = qw(ThrowCodeError ThrowTemplateError ThrowUserError); diff --git a/Bugzilla/Extension.pm b/Bugzilla/Extension.pm index 49422eca36..a02a2783ad 100644 --- a/Bugzilla/Extension.pm +++ b/Bugzilla/Extension.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Extension; + +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Field.pm b/Bugzilla/Field.pm index 228bea7379..64d5da5749 100644 --- a/Bugzilla/Field.pm +++ b/Bugzilla/Field.pm @@ -57,6 +57,7 @@ in addition to what is documented here. package Bugzilla::Field; +use 5.10.1; use strict; use base qw(Exporter Bugzilla::Object); diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm index 8c5873fdb1..2b6d8195fa 100644 --- a/Bugzilla/Field/Choice.pm +++ b/Bugzilla/Field/Choice.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Field::Choice; +use 5.10.1; +use strict; + use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use Bugzilla::Config qw(SetParam write_params); diff --git a/Bugzilla/Field/ChoiceInterface.pm b/Bugzilla/Field/ChoiceInterface.pm index ad0a61487a..c6ca2bc2d2 100644 --- a/Bugzilla/Field/ChoiceInterface.pm +++ b/Bugzilla/Field/ChoiceInterface.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Field::ChoiceInterface; + +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index 22a42d773f..5c77eb7cf8 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Flag; +use 5.10.1; +use strict; + =head1 NAME Bugzilla::Flag - A module to deal with Bugzilla flag values. diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index d313a62b90..7f29c4266f 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::FlagType; +use 5.10.1; +use strict; + =head1 NAME Bugzilla::FlagType - A module to deal with Bugzilla flag types. diff --git a/Bugzilla/Group.pm b/Bugzilla/Group.pm index 2d4e5a0a48..a5b108723c 100644 --- a/Bugzilla/Group.pm +++ b/Bugzilla/Group.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Group; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Hook.pm b/Bugzilla/Hook.pm index 3b8b528051..5ac07046e8 100644 --- a/Bugzilla/Hook.pm +++ b/Bugzilla/Hook.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Hook; + +use 5.10.1; use strict; sub process { diff --git a/Bugzilla/Install.pm b/Bugzilla/Install.pm index 4954dbfd03..d36bd2d72a 100644 --- a/Bugzilla/Install.pm +++ b/Bugzilla/Install.pm @@ -15,6 +15,7 @@ package Bugzilla::Install; # make those assumptions, then it should go into one of the # packages under the Bugzilla::Install namespace. +use 5.10.1; use strict; use Bugzilla::Component; @@ -25,7 +26,7 @@ use Bugzilla::Group; use Bugzilla::Product; use Bugzilla::User; use Bugzilla::User::Setting; -use Bugzilla::Util qw(get_text say); +use Bugzilla::Util qw(get_text); use Bugzilla::Version; use constant STATUS_WORKFLOW => ( diff --git a/Bugzilla/Install/CPAN.pm b/Bugzilla/Install/CPAN.pm index 10e0cce668..a0f059927d 100644 --- a/Bugzilla/Install/CPAN.pm +++ b/Bugzilla/Install/CPAN.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Install::CPAN; + +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT = qw( BZ_LIB diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index a6f0884828..abf57ac27c 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -10,6 +10,7 @@ package Bugzilla::Install::DB; # NOTE: This package may "use" any modules that it likes, # localconfig is available, and params are up to date. +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Filesystem.pm b/Bugzilla/Install/Filesystem.pm index cf61a6ec25..6b768cbbb6 100644 --- a/Bugzilla/Install/Filesystem.pm +++ b/Bugzilla/Install/Filesystem.pm @@ -15,6 +15,7 @@ package Bugzilla::Install::Filesystem; # * Files do not have the correct permissions. # * The database does not exist. +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Localconfig.pm b/Bugzilla/Install/Localconfig.pm index 4f1579c862..4e54da3cfa 100644 --- a/Bugzilla/Install/Localconfig.pm +++ b/Bugzilla/Install/Localconfig.pm @@ -15,6 +15,7 @@ package Bugzilla::Install::Localconfig; # * Files do not have the correct permissions # * The database is not up to date +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm index 24aa1cb822..5dbb8344ab 100644 --- a/Bugzilla/Install/Requirements.pm +++ b/Bugzilla/Install/Requirements.pm @@ -13,6 +13,7 @@ package Bugzilla::Install::Requirements; # Subroutines may "require" and "import" from modules, but they # MUST NOT "use." +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Util.pm b/Bugzilla/Install/Util.pm index ed23d00934..8548717e41 100644 --- a/Bugzilla/Install/Util.pm +++ b/Bugzilla/Install/Util.pm @@ -11,6 +11,7 @@ package Bugzilla::Install::Util; # module may require *only* Bugzilla::Constants and built-in # perl modules. +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Job/Mailer.pm b/Bugzilla/Job/Mailer.pm index 958089e455..d6f08adabb 100644 --- a/Bugzilla/Job/Mailer.pm +++ b/Bugzilla/Job/Mailer.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Job::Mailer; + +use 5.10.1; use strict; + use Bugzilla::Mailer; BEGIN { eval "use base qw(TheSchwartz::Worker)"; } diff --git a/Bugzilla/JobQueue.pm b/Bugzilla/JobQueue.pm index f8bd6a615e..18723446cb 100644 --- a/Bugzilla/JobQueue.pm +++ b/Bugzilla/JobQueue.pm @@ -7,6 +7,7 @@ package Bugzilla::JobQueue; +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/JobQueue/Runner.pm b/Bugzilla/JobQueue/Runner.pm index 6c837369f9..e38e6ce590 100644 --- a/Bugzilla/JobQueue/Runner.pm +++ b/Bugzilla/JobQueue/Runner.pm @@ -11,7 +11,9 @@ package Bugzilla::JobQueue::Runner; +use 5.10.1; use strict; + use Cwd qw(abs_path); use File::Basename; use File::Copy; diff --git a/Bugzilla/Keyword.pm b/Bugzilla/Keyword.pm index a6e0b6d270..b933c11f81 100644 --- a/Bugzilla/Keyword.pm +++ b/Bugzilla/Keyword.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Keyword; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Error; diff --git a/Bugzilla/Mailer.pm b/Bugzilla/Mailer.pm index 5ef7310635..203121de17 100644 --- a/Bugzilla/Mailer.pm +++ b/Bugzilla/Mailer.pm @@ -7,6 +7,7 @@ package Bugzilla::Mailer; +use 5.10.1; use strict; use base qw(Exporter); diff --git a/Bugzilla/Migrate.pm b/Bugzilla/Migrate.pm index 0975a0633b..6dbe6ef10c 100644 --- a/Bugzilla/Migrate.pm +++ b/Bugzilla/Migrate.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Migrate; + +use 5.10.1; use strict; use Bugzilla::Attachment; @@ -16,7 +18,7 @@ use Bugzilla::Error; use Bugzilla::Install::Requirements (); use Bugzilla::Install::Util qw(indicate_progress); use Bugzilla::Product; -use Bugzilla::Util qw(get_text trim generate_random_password say); +use Bugzilla::Util qw(get_text trim generate_random_password); use Bugzilla::User (); use Bugzilla::Status (); use Bugzilla::Version; diff --git a/Bugzilla/Migrate/Gnats.pm b/Bugzilla/Migrate/Gnats.pm index 05d3b3739f..6022bdbbb7 100644 --- a/Bugzilla/Migrate/Gnats.pm +++ b/Bugzilla/Migrate/Gnats.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Migrate::Gnats; + +use 5.10.1; use strict; + use base qw(Bugzilla::Migrate); use Bugzilla::Constants; diff --git a/Bugzilla/Milestone.pm b/Bugzilla/Milestone.pm index ef8ecbab57..8f243232da 100644 --- a/Bugzilla/Milestone.pm +++ b/Bugzilla/Milestone.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Milestone; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index 531b817111..fa4c4e7900 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Object; +use 5.10.1; +use strict; + use Bugzilla::Constants; use Bugzilla::Hook; use Bugzilla::Util; diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm index fdebc6b007..894db422ee 100644 --- a/Bugzilla/Product.pm +++ b/Bugzilla/Product.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Product; + +use 5.10.1; use strict; + use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/RNG.pm b/Bugzilla/RNG.pm index 457d2cae02..59eb3195c6 100644 --- a/Bugzilla/RNG.pm +++ b/Bugzilla/RNG.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::RNG; + +use 5.10.1; use strict; + use base qw(Exporter); use Bugzilla::Constants qw(ON_WINDOWS); diff --git a/Bugzilla/Report.pm b/Bugzilla/Report.pm index 4c9f332264..097bbb0743 100644 --- a/Bugzilla/Report.pm +++ b/Bugzilla/Report.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Report; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::CGI; diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index aaa3c208b5..c64ff6de2e 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -5,9 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +package Bugzilla::Search; + +use 5.10.1; use strict; -package Bugzilla::Search; use base qw(Exporter); @Bugzilla::Search::EXPORT = qw( IsValidQueryType diff --git a/Bugzilla/Search/Clause.pm b/Bugzilla/Search/Clause.pm index 6e682e7cf9..ff50cb944e 100644 --- a/Bugzilla/Search/Clause.pm +++ b/Bugzilla/Search/Clause.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Search::Clause; + +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/Search/Condition.pm b/Bugzilla/Search/Condition.pm index 2ca7237276..ac6947484a 100644 --- a/Bugzilla/Search/Condition.pm +++ b/Bugzilla/Search/Condition.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Search::Condition; + +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT_OK = qw(condition); diff --git a/Bugzilla/Search/Quicksearch.pm b/Bugzilla/Search/Quicksearch.pm index 17c5635ff1..d686fde03c 100644 --- a/Bugzilla/Search/Quicksearch.pm +++ b/Bugzilla/Search/Quicksearch.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Quicksearch; -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/Search/Recent.pm b/Bugzilla/Search/Recent.pm index 02c3ec37a5..00b71a91df 100644 --- a/Bugzilla/Search/Recent.pm +++ b/Bugzilla/Search/Recent.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Search::Recent; + +use 5.10.1; use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Search/Saved.pm b/Bugzilla/Search/Saved.pm index c9885c9cec..f6e9badabb 100644 --- a/Bugzilla/Search/Saved.pm +++ b/Bugzilla/Search/Saved.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Search::Saved; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::CGI; diff --git a/Bugzilla/Send/Sendmail.pm b/Bugzilla/Send/Sendmail.pm index 9513134f44..b15f48043f 100644 --- a/Bugzilla/Send/Sendmail.pm +++ b/Bugzilla/Send/Sendmail.pm @@ -7,6 +7,7 @@ package Bugzilla::Send::Sendmail; +use 5.10.1; use strict; use base qw(Email::Send::Sendmail); diff --git a/Bugzilla/Series.pm b/Bugzilla/Series.pm index f2ed9a4aff..e7c2ef005a 100644 --- a/Bugzilla/Series.pm +++ b/Bugzilla/Series.pm @@ -5,8 +5,6 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - # This module implements a series - a set of data to be plotted on a chart. # # This Series is in the database if and only if self->{'series_id'} is defined. @@ -16,6 +14,9 @@ use strict; package Bugzilla::Series; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::Util; diff --git a/Bugzilla/Status.pm b/Bugzilla/Status.pm index 2821f7c6e9..33277fed7b 100644 --- a/Bugzilla/Status.pm +++ b/Bugzilla/Status.pm @@ -5,11 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Status; -use Bugzilla::Error; +use 5.10.1; +use strict; + # This subclasses Bugzilla::Field::Choice instead of implementing # ChoiceInterface, because a bug status literally is a special type # of Field::Choice, not just an object that happens to have the same @@ -23,6 +23,8 @@ use base qw(Bugzilla::Field::Choice Exporter); closed_bug_statuses ); +use Bugzilla::Error; + ################################ ##### Initialization ##### ################################ diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index a38d07e7ff..6685a74318 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -8,6 +8,7 @@ package Bugzilla::Template; +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Template/Context.pm b/Bugzilla/Template/Context.pm index 9dc1f08f9e..937ac33b13 100644 --- a/Bugzilla/Template/Context.pm +++ b/Bugzilla/Template/Context.pm @@ -7,7 +7,10 @@ # This exists to implement the template-before_process hook. package Bugzilla::Template::Context; + +use 5.10.1; use strict; + use base qw(Template::Context); use Bugzilla::Hook; diff --git a/Bugzilla/Template/Plugin/Bugzilla.pm b/Bugzilla/Template/Plugin/Bugzilla.pm index e2b59c7a82..044c9eed12 100644 --- a/Bugzilla/Template/Plugin/Bugzilla.pm +++ b/Bugzilla/Template/Plugin/Bugzilla.pm @@ -7,6 +7,7 @@ package Bugzilla::Template::Plugin::Bugzilla; +use 5.10.1; use strict; use base qw(Template::Plugin); diff --git a/Bugzilla/Template/Plugin/Hook.pm b/Bugzilla/Template/Plugin/Hook.pm index f1de7a602c..52b3703dce 100644 --- a/Bugzilla/Template/Plugin/Hook.pm +++ b/Bugzilla/Template/Plugin/Hook.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Template::Plugin::Hook; + +use 5.10.1; use strict; + use base qw(Template::Plugin); use Bugzilla::Constants; diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm index 264a28db13..f7caa0e316 100644 --- a/Bugzilla/Token.pm +++ b/Bugzilla/Token.pm @@ -5,16 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Module Initialization -################################################################################ +package Bugzilla::Token; -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; -# Bundle the functions in this file together into the "Bugzilla::Token" package. -package Bugzilla::Token; - use Bugzilla::Constants; use Bugzilla::Error; use Bugzilla::Mailer; diff --git a/Bugzilla/Update.pm b/Bugzilla/Update.pm index 29133ecce0..6a10121995 100644 --- a/Bugzilla/Update.pm +++ b/Bugzilla/Update.pm @@ -7,6 +7,7 @@ package Bugzilla::Update; +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 0bf9450847..87255b20a0 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -5,16 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Module Initialization -################################################################################ +package Bugzilla::User; -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; -# This module implements utilities for dealing with Bugzilla users. -package Bugzilla::User; - use Bugzilla::Error; use Bugzilla::Util; use Bugzilla::Constants; diff --git a/Bugzilla/User/Setting.pm b/Bugzilla/User/Setting.pm index 6fadfb3523..52a5ff5aa4 100644 --- a/Bugzilla/User/Setting.pm +++ b/Bugzilla/User/Setting.pm @@ -8,7 +8,9 @@ package Bugzilla::User::Setting; +use 5.10.1; use strict; + use base qw(Exporter); diff --git a/Bugzilla/User/Setting/Lang.pm b/Bugzilla/User/Setting/Lang.pm index 71b01d62f6..0dcec9aa1b 100644 --- a/Bugzilla/User/Setting/Lang.pm +++ b/Bugzilla/User/Setting/Lang.pm @@ -7,6 +7,7 @@ package Bugzilla::User::Setting::Lang; +use 5.10.1; use strict; use base qw(Bugzilla::User::Setting); diff --git a/Bugzilla/User/Setting/Skin.pm b/Bugzilla/User/Setting/Skin.pm index c75ce7568e..3181fdded1 100644 --- a/Bugzilla/User/Setting/Skin.pm +++ b/Bugzilla/User/Setting/Skin.pm @@ -8,6 +8,7 @@ package Bugzilla::User::Setting::Skin; +use 5.10.1; use strict; use base qw(Bugzilla::User::Setting); diff --git a/Bugzilla/User/Setting/Timezone.pm b/Bugzilla/User/Setting/Timezone.pm index 91f997774f..962e0a7ff0 100644 --- a/Bugzilla/User/Setting/Timezone.pm +++ b/Bugzilla/User/Setting/Timezone.pm @@ -7,6 +7,7 @@ package Bugzilla::User::Setting::Timezone; +use 5.10.1; use strict; use DateTime::TimeZone; diff --git a/Bugzilla/UserAgent.pm b/Bugzilla/UserAgent.pm index b5d5521305..627120efc0 100644 --- a/Bugzilla/UserAgent.pm +++ b/Bugzilla/UserAgent.pm @@ -7,7 +7,9 @@ package Bugzilla::UserAgent; +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT = qw(detect_platform detect_op_sys); diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm index 78ef21e1d7..9e1a01e2d1 100644 --- a/Bugzilla/Util.pm +++ b/Bugzilla/Util.pm @@ -7,8 +7,8 @@ package Bugzilla::Util; +use 5.10.1; use strict; -use feature ':5.10'; use base qw(Exporter); @Bugzilla::Util::EXPORT = qw(trick_taint detaint_natural detaint_signed @@ -16,7 +16,7 @@ use base qw(Exporter); css_class_quote html_light_quote i_am_cgi correct_urlbase remote_ip validate_ip do_ssl_redirect_if_required use_attachbase - diff_arrays on_main_db say + diff_arrays on_main_db trim wrap_hard wrap_comment find_wrap_point format_time validate_date validate_time datetime_from is_7bit_clean bz_crypt generate_random_password diff --git a/Bugzilla/Version.pm b/Bugzilla/Version.pm index 02f2a70d81..449630a6d9 100644 --- a/Bugzilla/Version.pm +++ b/Bugzilla/Version.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Version; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Install::Util qw(vers_cmp); diff --git a/Bugzilla/WebService.pm b/Bugzilla/WebService.pm index 88ffa3f961..38e0f510fb 100644 --- a/Bugzilla/WebService.pm +++ b/Bugzilla/WebService.pm @@ -8,7 +8,10 @@ # This is the base class for $self in WebService method calls. For the # actual RPC server, see Bugzilla::WebService::Server and its subclasses. package Bugzilla::WebService; + +use 5.10.1; use strict; + use Bugzilla::WebService::Server; # Used by the JSON-RPC server to convert incoming date fields apprpriately. diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index 75c3c2f61c..1c8811b65f 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Bug; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Comment; diff --git a/Bugzilla/WebService/Bugzilla.pm b/Bugzilla/WebService/Bugzilla.pm index f441cee90c..4711105660 100644 --- a/Bugzilla/WebService/Bugzilla.pm +++ b/Bugzilla/WebService/Bugzilla.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Bugzilla; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Constants; use Bugzilla::Util qw(datetime_from); diff --git a/Bugzilla/WebService/Constants.pm b/Bugzilla/WebService/Constants.pm index 491970291c..dcd3a9fd78 100644 --- a/Bugzilla/WebService/Constants.pm +++ b/Bugzilla/WebService/Constants.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Constants; +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT = qw( diff --git a/Bugzilla/WebService/Group.pm b/Bugzilla/WebService/Group.pm index d7506aa3d9..79ce1658b0 100644 --- a/Bugzilla/WebService/Group.pm +++ b/Bugzilla/WebService/Group.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Group; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Constants; use Bugzilla::Error; diff --git a/Bugzilla/WebService/Product.pm b/Bugzilla/WebService/Product.pm index 18594d7260..8d6fc5df20 100644 --- a/Bugzilla/WebService/Product.pm +++ b/Bugzilla/WebService/Product.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Product; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Product; use Bugzilla::User; diff --git a/Bugzilla/WebService/Server.pm b/Bugzilla/WebService/Server.pm index a43ed204c9..5f17951781 100644 --- a/Bugzilla/WebService/Server.pm +++ b/Bugzilla/WebService/Server.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::WebService::Server; + +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/WebService/Server/JSONRPC.pm b/Bugzilla/WebService/Server/JSONRPC.pm index 804d7874ef..46dd6b8da8 100644 --- a/Bugzilla/WebService/Server/JSONRPC.pm +++ b/Bugzilla/WebService/Server/JSONRPC.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Server::JSONRPC; +use 5.10.1; use strict; + use Bugzilla::WebService::Server; BEGIN { our @ISA = qw(Bugzilla::WebService::Server); diff --git a/Bugzilla/WebService/Server/XMLRPC.pm b/Bugzilla/WebService/Server/XMLRPC.pm index e8fb5de997..22396bce1d 100644 --- a/Bugzilla/WebService/Server/XMLRPC.pm +++ b/Bugzilla/WebService/Server/XMLRPC.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Server::XMLRPC; +use 5.10.1; use strict; + use XMLRPC::Transport::HTTP; use Bugzilla::WebService::Server; if ($ENV{MOD_PERL}) { @@ -66,7 +68,10 @@ sub handle_login { # This exists to validate input parameters (which XMLRPC::Lite doesn't do) # and also, in some cases, to more-usefully decode them. package Bugzilla::XMLRPC::Deserializer; + +use 5.10.1; use strict; + # We can't use "use base" because XMLRPC::Serializer doesn't return # a true value. use XMLRPC::Lite; @@ -161,7 +166,10 @@ sub _validation_subs { 1; package Bugzilla::XMLRPC::SOM; + +use 5.10.1; use strict; + use XMLRPC::Lite; our @ISA = qw(XMLRPC::SOM); use Bugzilla::WebService::Util qw(taint_data); @@ -184,8 +192,11 @@ sub paramsin { # This package exists to fix a UTF-8 bug in SOAP::Lite. # See http://rt.cpan.org/Public/Bug/Display.html?id=32952. package Bugzilla::XMLRPC::Serializer; -use Scalar::Util qw(blessed); + +use 5.10.1; use strict; + +use Scalar::Util qw(blessed); # We can't use "use base" because XMLRPC::Serializer doesn't return # a true value. use XMLRPC::Lite; diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm index 05bbf90ca3..ee1442d725 100644 --- a/Bugzilla/WebService/User.pm +++ b/Bugzilla/WebService/User.pm @@ -7,10 +7,11 @@ package Bugzilla::WebService::User; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); -use Bugzilla; use Bugzilla::Constants; use Bugzilla::Error; use Bugzilla::Group; diff --git a/Bugzilla/WebService/Util.pm b/Bugzilla/WebService/Util.pm index 83b9250156..0c206e0307 100644 --- a/Bugzilla/WebService/Util.pm +++ b/Bugzilla/WebService/Util.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::WebService::Util; + +use 5.10.1; use strict; + use base qw(Exporter); # We have to "require", not "use" this, because otherwise it tries to diff --git a/Bugzilla/Whine.pm b/Bugzilla/Whine.pm index 3796198225..fba6e714ab 100644 --- a/Bugzilla/Whine.pm +++ b/Bugzilla/Whine.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Whine; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Whine/Query.pm b/Bugzilla/Whine/Query.pm index e52cad66ea..3c63e80571 100644 --- a/Bugzilla/Whine/Query.pm +++ b/Bugzilla/Whine/Query.pm @@ -7,6 +7,7 @@ package Bugzilla::Whine::Query; +use 5.10.1; use strict; use base qw(Bugzilla::Object); diff --git a/Bugzilla/Whine/Schedule.pm b/Bugzilla/Whine/Schedule.pm index 102b5d825f..a96c728f23 100644 --- a/Bugzilla/Whine/Schedule.pm +++ b/Bugzilla/Whine/Schedule.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Whine::Schedule; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/admin.cgi b/admin.cgi index 273ec8e892..0767b07a39 100755 --- a/admin.cgi +++ b/admin.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/attachment.cgi b/attachment.cgi index e696c95a76..775a91f000 100755 --- a/attachment.cgi +++ b/attachment.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -24,11 +19,9 @@ use Bugzilla::FlagType; use Bugzilla::User; use Bugzilla::Util; use Bugzilla::Bug; -use Bugzilla::Field; use Bugzilla::Attachment; use Bugzilla::Attachment::PatchReader; use Bugzilla::Token; -use Bugzilla::Keyword; use Encode qw(encode find_encoding); @@ -40,10 +33,6 @@ local our $cgi = Bugzilla->cgi; local our $template = Bugzilla->template; local our $vars = {}; -################################################################################ -# Main Body Execution -################################################################################ - # All calls to this script should contain an "action" variable whose # value determines what the user wants to do. The code below checks # the value of that variable and runs the appropriate code. If none is diff --git a/buglist.cgi b/buglist.cgi index 8185491d92..057caa935e 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/chart.cgi b/chart.cgi index 0fa073e581..5f4573fd04 100755 --- a/chart.cgi +++ b/chart.cgi @@ -27,6 +27,7 @@ # Bonus: # Offer subscription when you get a "series already exists" error? +use 5.10.1; use strict; use lib qw(. lib); @@ -37,7 +38,6 @@ use Bugzilla::Error; use Bugzilla::Util; use Bugzilla::Chart; use Bugzilla::Series; -use Bugzilla::User; use Bugzilla::Token; # For most scripts we don't make $cgi and $template global variables. But diff --git a/colchange.cgi b/colchange.cgi index 835a8ef347..0aa6c7cbaf 100755 --- a/colchange.cgi +++ b/colchange.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); @@ -15,7 +16,6 @@ use Bugzilla::Util; use Bugzilla::CGI; use Bugzilla::Search::Saved; use Bugzilla::Error; -use Bugzilla::User; use Bugzilla::Token; use Storable qw(dclone); diff --git a/collectstats.pl b/collectstats.pl index c1ad338f5c..7336714bb8 100755 --- a/collectstats.pl +++ b/collectstats.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/config.cgi b/config.cgi index 7dc2e3afb3..c4f64a007c 100755 --- a/config.cgi +++ b/config.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/contrib/Bugzilla.pm b/contrib/Bugzilla.pm index 6bfc07e2a3..fbae60de4a 100644 --- a/contrib/Bugzilla.pm +++ b/contrib/Bugzilla.pm @@ -4,6 +4,7 @@ package Bugzilla; +use 5.10.1; use strict; ####################################################################### diff --git a/createaccount.cgi b/createaccount.cgi index e3b83205bb..e2dbbf62fa 100755 --- a/createaccount.cgi +++ b/createaccount.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/describecomponents.cgi b/describecomponents.cgi index 3a70f29bb0..8544346af5 100755 --- a/describecomponents.cgi +++ b/describecomponents.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/describekeywords.cgi b/describekeywords.cgi index b67b9c3d9e..ef06349602 100755 --- a/describekeywords.cgi +++ b/describekeywords.cgi @@ -6,12 +6,12 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); use Bugzilla; use Bugzilla::Error; -use Bugzilla::User; use Bugzilla::Keyword; my $user = Bugzilla->login(); diff --git a/docs/lib/Pod/Simple/HTML/Bugzilla.pm b/docs/lib/Pod/Simple/HTML/Bugzilla.pm index cc607be7c7..4a15176711 100644 --- a/docs/lib/Pod/Simple/HTML/Bugzilla.pm +++ b/docs/lib/Pod/Simple/HTML/Bugzilla.pm @@ -7,7 +7,9 @@ package Pod::Simple::HTML::Bugzilla; +use 5.10.1; use strict; + use base qw(Pod::Simple::HTML); # Without this constant, HTMLBatch will throw undef warnings. diff --git a/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm b/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm index 366ceb7a00..52a09910fa 100644 --- a/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm +++ b/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm @@ -7,7 +7,9 @@ package Pod::Simple::HTMLBatch::Bugzilla; +use 5.10.1; use strict; + use base qw(Pod::Simple::HTMLBatch); # This is the same hack that HTMLBatch does to "import" this subroutine. diff --git a/docs/makedocs.pl b/docs/makedocs.pl index 4bf1fb4a0a..ea08d8258c 100755 --- a/docs/makedocs.pl +++ b/docs/makedocs.pl @@ -8,7 +8,9 @@ # This script compiles all the documentation. +use 5.10.1; use strict; + use Cwd; # We need to be in this directory to use our libraries. @@ -87,8 +89,8 @@ sub MakeDocs { my ($name, $cmdline) = @_; - print "Creating $name documentation ...\n" if defined $name; - print "$cmdline\n\n"; + say "Creating $name documentation ..." if defined $name; + say "$cmdline\n"; system $cmdline; print "\n"; @@ -96,7 +98,7 @@ sub MakeDocs { sub make_pod { - print "Creating API documentation...\n"; + say "Creating API documentation..."; my $converter = Pod::Simple::HTMLBatch::Bugzilla->new; # Don't output progress information. diff --git a/duplicates.cgi b/duplicates.cgi index 01962218bd..d501b0e16a 100755 --- a/duplicates.cgi +++ b/duplicates.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editclassifications.cgi b/editclassifications.cgi index 3a2647af69..3d93057b91 100755 --- a/editclassifications.cgi +++ b/editclassifications.cgi @@ -7,6 +7,7 @@ # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editcomponents.cgi b/editcomponents.cgi index 7ff1dae811..12a449fd45 100755 --- a/editcomponents.cgi +++ b/editcomponents.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editfields.cgi b/editfields.cgi index 5d9e053670..5ac9dcccec 100755 --- a/editfields.cgi +++ b/editfields.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editflagtypes.cgi b/editflagtypes.cgi index e9c430d7dc..c52bab7173 100755 --- a/editflagtypes.cgi +++ b/editflagtypes.cgi @@ -6,15 +6,10 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; use lib qw(. lib); -# Use Bugzilla's flag modules for handling flag types. use Bugzilla; use Bugzilla::Constants; use Bugzilla::Flag; diff --git a/editgroups.cgi b/editgroups.cgi index d603ab1834..87c44f03c5 100755 --- a/editgroups.cgi +++ b/editgroups.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editkeywords.cgi b/editkeywords.cgi index cbaa308fb3..7e14f80cdc 100755 --- a/editkeywords.cgi +++ b/editkeywords.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editmilestones.cgi b/editmilestones.cgi index 93152cd50a..3eeb300ab3 100755 --- a/editmilestones.cgi +++ b/editmilestones.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editparams.cgi b/editparams.cgi index b522fd4140..3486d70612 100755 --- a/editparams.cgi +++ b/editparams.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editproducts.cgi b/editproducts.cgi index b4f1649952..137f142855 100755 --- a/editproducts.cgi +++ b/editproducts.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editsettings.cgi b/editsettings.cgi index 17740cd5c1..bf5e2025b2 100755 --- a/editsettings.cgi +++ b/editsettings.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editusers.cgi b/editusers.cgi index e2675921bd..30a747ded2 100755 --- a/editusers.cgi +++ b/editusers.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editvalues.cgi b/editvalues.cgi index 60c39c9ea5..61fe247234 100755 --- a/editvalues.cgi +++ b/editvalues.cgi @@ -10,6 +10,7 @@ # or select boxes. It is largely a copy of editmilestones.cgi, but # with some cleanup. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editversions.cgi b/editversions.cgi index 4951c272ab..1d056c67b9 100755 --- a/editversions.cgi +++ b/editversions.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editwhines.cgi b/editwhines.cgi index 5227f1d62d..e93e552d97 100755 --- a/editwhines.cgi +++ b/editwhines.cgi @@ -10,8 +10,8 @@ # Script Initialization ################################################################################ +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/editworkflow.cgi b/editworkflow.cgi index 36b8ab8f9b..68cd984586 100755 --- a/editworkflow.cgi +++ b/editworkflow.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/email_in.pl b/email_in.pl index 6be7be8cff..183833008b 100755 --- a/email_in.pl +++ b/email_in.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use warnings; diff --git a/enter_bug.cgi b/enter_bug.cgi index 7a8cebf43c..a4dde21ba0 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -16,8 +16,8 @@ # ############################################################################## +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/extensions/create.pl b/extensions/create.pl index 5f1b884d25..c48f60df82 100755 --- a/extensions/create.pl +++ b/extensions/create.pl @@ -6,8 +6,10 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); + use Bugzilla; use Bugzilla::Constants; use Bugzilla::Error; @@ -54,7 +56,7 @@ foreach my $template_file (keys %create_files) { close($fh); } -print get_text('extension_created', $vars), "\n"; +say get_text('extension_created', $vars); __END__ diff --git a/importxml.pl b/importxml.pl index f34317d5ae..1105e25172 100755 --- a/importxml.pl +++ b/importxml.pl @@ -10,6 +10,7 @@ # a new bug into bugzilla. Everything before the beginning param('logout')) { $cgi->delete('logout'); } -############################################################################### -# Main Body Execution -############################################################################### - # Return the appropriate HTTP response headers. print $cgi->header(); diff --git a/install-module.pl b/install-module.pl index 4663777599..37ea8cc410 100755 --- a/install-module.pl +++ b/install-module.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use warnings; diff --git a/jobqueue.pl b/jobqueue.pl index 1b956917e0..6ba288d2ec 100755 --- a/jobqueue.pl +++ b/jobqueue.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use Cwd qw(abs_path); diff --git a/jsonrpc.cgi b/jsonrpc.cgi index 0d275f83cb..6a60c9d3ee 100755 --- a/jsonrpc.cgi +++ b/jsonrpc.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/migrate.pl b/migrate.pl index de4265b0be..0ce85fa154 100755 --- a/migrate.pl +++ b/migrate.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use File::Basename; BEGIN { chdir dirname($0); } diff --git a/mod_perl.pl b/mod_perl.pl index ac6956b1b9..81aae301ed 100644 --- a/mod_perl.pl +++ b/mod_perl.pl @@ -7,6 +7,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::ModPerl; + +use 5.10.1; use strict; use warnings; @@ -107,7 +109,10 @@ foreach my $file (glob "$cgi_path/*.cgi") { } package Bugzilla::ModPerl::ResponseHandler; + +use 5.10.1; use strict; + use base qw(ModPerl::Registry); use Bugzilla; @@ -132,7 +137,10 @@ sub handler : method { package Bugzilla::ModPerl::CleanupHandler; + +use 5.10.1; use strict; + use Apache2::Const -compile => qw(OK); sub handler { diff --git a/page.cgi b/page.cgi index e5192ab502..be0dcd7ff3 100755 --- a/page.cgi +++ b/page.cgi @@ -13,8 +13,8 @@ # a content-type, e.g. html. ############################################################################### +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/post_bug.cgi b/post_bug.cgi index b150492344..b38707365e 100755 --- a/post_bug.cgi +++ b/post_bug.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); @@ -17,11 +18,7 @@ use Bugzilla::Util; use Bugzilla::Error; use Bugzilla::Bug; use Bugzilla::User; -use Bugzilla::Field; use Bugzilla::Hook; -use Bugzilla::Product; -use Bugzilla::Component; -use Bugzilla::Keyword; use Bugzilla::Token; use Bugzilla::Flag; diff --git a/process_bug.cgi b/process_bug.cgi index 29cc54e9f2..d9ae9c109c 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -18,8 +18,8 @@ # 3) If we are processing just the one id, then it is stored in @idlist for # later processing. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/query.cgi b/query.cgi index df3d9cadf5..29e278c6d5 100755 --- a/query.cgi +++ b/query.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/quips.cgi b/quips.cgi index 266ed516f4..4ed40a5479 100755 --- a/quips.cgi +++ b/quips.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/relogin.cgi b/relogin.cgi index 57240db43d..e2effd1058 100755 --- a/relogin.cgi +++ b/relogin.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/report.cgi b/report.cgi index 0241f42b54..a5d170825e 100755 --- a/report.cgi +++ b/report.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/reports.cgi b/reports.cgi index 66f4b05d75..c8c319f41b 100755 --- a/reports.cgi +++ b/reports.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/request.cgi b/request.cgi index 3bae8c094a..17e6c926d7 100755 --- a/request.cgi +++ b/request.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -34,10 +29,6 @@ my $action = $cgi->param('action') || ''; print $cgi->header(); -################################################################################ -# Main Body Execution -################################################################################ - my $fields; $fields->{'requester'}->{'type'} = 'single'; # If the user doesn't restrict his search to requests from the wind diff --git a/runtests.pl b/runtests.pl index 09963e84e6..6a64500079 100755 --- a/runtests.pl +++ b/runtests.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use diagnostics; use strict; use lib qw(lib); diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 3a869ef9fa..ad5925d064 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/sanitycheck.pl b/sanitycheck.pl index a360bf8c0b..819c661528 100755 --- a/sanitycheck.pl +++ b/sanitycheck.pl @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/search_plugin.cgi b/search_plugin.cgi index 3809159c72..e9b281ec2d 100755 --- a/search_plugin.cgi +++ b/search_plugin.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/show_activity.cgi b/show_activity.cgi index d161382f78..31181a63b5 100755 --- a/show_activity.cgi +++ b/show_activity.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/show_bug.cgi b/show_bug.cgi index 48d75512b9..e5ae4bfd05 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index 842e12f2a9..ff0602d46c 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use File::Temp; diff --git a/showdependencytree.cgi b/showdependencytree.cgi index f8844b702a..4031ed2637 100755 --- a/showdependencytree.cgi +++ b/showdependencytree.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/summarize_time.cgi b/summarize_time.cgi index fa13a5162e..e06d3257d3 100755 --- a/summarize_time.cgi +++ b/summarize_time.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Date::Parse; # strptime diff --git a/t/002goodperl.t b/t/002goodperl.t index e691b39ddf..4826c7712b 100644 --- a/t/002goodperl.t +++ b/t/002goodperl.t @@ -16,7 +16,7 @@ use lib 't'; use Support::Files; -use Test::More tests => (scalar(@Support::Files::testitems) * 3); +use Test::More tests => (scalar(@Support::Files::testitems) * 4); my @testitems = @Support::Files::testitems; # get the files to test. @@ -84,6 +84,28 @@ foreach my $file (@testitems) { } } +foreach my $file (@testitems) { + my $found_use_feature = 0; + $file =~ s/\s.*$//; # nuke everything after the first space (#comment) + next if (!$file); # skip null entries + if (! open (FILE, $file)) { + ok(0,"could not open $file --WARNING"); + next; + } + while (my $file_line = ) { + if ($file_line =~ m/^\s*use 5.10.1/) { + $found_use_feature = 1; + last; + } + } + close (FILE); + if ($found_use_feature) { + ok(1,"$file requires Perl 5.10.1"); + } else { + ok(0,"$file DOES NOT require Perl 5.10.1 --WARNING"); + } +} + # Check to see that all error messages use tags (for l10n reasons.) foreach my $file (@testitems) { $file =~ s/\s.*$//; # nuke everything after the first space (#comment) diff --git a/testagent.cgi b/testagent.cgi index 3480f877e8..c3220cab52 100755 --- a/testagent.cgi +++ b/testagent.cgi @@ -10,7 +10,9 @@ # are being run instead of shown. This script does not rely on database access # or correct params. +use 5.10.1; use strict; -print "content-type:text/plain\n\n"; -print "OK " . ($::ENV{MOD_PERL} || "mod_cgi") . "\n"; + +say "content-type:text/plain\n"; +say "OK " . ($::ENV{MOD_PERL} || "mod_cgi"); exit; diff --git a/testserver.pl b/testserver.pl index 488524792c..3eb25a13bd 100755 --- a/testserver.pl +++ b/testserver.pl @@ -10,12 +10,12 @@ # as its only argument. It attempts to troubleshoot as many installation # issues as possible. +use 5.10.1; use strict; use lib qw(. lib); use Bugzilla; use Bugzilla::Constants; -use Bugzilla::Util qw(say); use Socket; diff --git a/token.cgi b/token.cgi index 62f1f51210..c1630ec91f 100755 --- a/token.cgi +++ b/token.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/userprefs.cgi b/userprefs.cgi index 1b63474568..a80184d51f 100755 --- a/userprefs.cgi +++ b/userprefs.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/votes.cgi b/votes.cgi index 609ec332a0..032dc1b8ae 100755 --- a/votes.cgi +++ b/votes.cgi @@ -9,8 +9,10 @@ # This script remains as a backwards-compatibility URL for before # the time that Voting was an extension. +use 5.10.1; use strict; use lib qw(. lib); + use Bugzilla; use Bugzilla::Error; diff --git a/whine.pl b/whine.pl index 7dca2620b8..cb52029c08 100755 --- a/whine.pl +++ b/whine.pl @@ -10,8 +10,8 @@ # Script Initialization ################################################################################ +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/whineatnews.pl b/whineatnews.pl index 4a5c967c6a..c813811620 100755 --- a/whineatnews.pl +++ b/whineatnews.pl @@ -14,6 +14,7 @@ # param. (We have NEW and REOPENED in there to keep compatibility with old # Bugzillas.) +use 5.10.1; use strict; use lib qw(. lib); diff --git a/xmlrpc.cgi b/xmlrpc.cgi index 8bf9f9f1e0..a8092b25d1 100755 --- a/xmlrpc.cgi +++ b/xmlrpc.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib);