From: Timo Sirainen Date: Fri, 21 Mar 2025 19:30:12 +0000 (+0200) Subject: lib-storage: mailbox_list_index_refresh() - Fix error handling when called many times... X-Git-Tag: 2.4.2~867 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=100bdf2a9bc1e2498bd88a2a7b959ed638018023;p=thirdparty%2Fdovecot%2Fcore.git lib-storage: mailbox_list_index_refresh() - Fix error handling when called many times rapidly The error could have been cleared out between the calls, so set the repeated calls as internal failure. --- diff --git a/src/lib-storage/list/mailbox-list-index.c b/src/lib-storage/list/mailbox-list-index.c index 5f55a27cf8..5865121bac 100644 --- a/src/lib-storage/list/mailbox-list-index.c +++ b/src/lib-storage/list/mailbox-list-index.c @@ -620,7 +620,10 @@ int mailbox_list_index_refresh(struct mailbox_list *list) it. when we're accessing many mailboxes at once (e.g. opening a virtual mailbox) we don't want to stat/read the index every single time. */ - return ilist->last_refresh_success ? 0 : -1; + if (ilist->last_refresh_success) + return 0; + mailbox_list_set_internal_error(list); + return -1; } return mailbox_list_index_refresh_force(list);