From: Aki Tuomi <cmouse@desteem.org>
Date: Tue, 29 Sep 2015 17:38:40 +0000 (+0300)
Subject: Correct iterator usage
X-Git-Tag: dnsdist-1.0.0-alpha1~248^2~12^2~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1022de447e2275d9f6303899e5fbc5eaf938d782;p=thirdparty%2Fpdns.git

Correct iterator usage

fix cid#1311862
---

diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index 5e34841c56..566bb604ec 100644
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -574,7 +574,7 @@ string makeTSIGMessageFromTSIGPacket(const string& opacket, unsigned int tsigOff
     //    dw.xfrBlob(trc->d_otherData);
   }
   const vector<uint8_t>& signRecord=dw.getRecordBeingWritten();
-  message.append(&*signRecord.begin(), &*signRecord.end());
+  message.append(signRecord.begin(), signRecord.end());
   return message;
 }
 
@@ -614,7 +614,7 @@ void addTSIG(DNSPacketWriter& pw, TSIGRecordContent* trc, const DNSName& tsigkey
   }
   
   const vector<uint8_t>& signRecord=dw.getRecordBeingWritten();
-  toSign.append(&*signRecord.begin(), &*signRecord.end());
+  toSign.append(signRecord.begin(), signRecord.end());
 
   if (algo == TSIG_GSS) {
     if (!gss_add_signature(tsigkeyname, toSign, trc->d_mac)) {
diff --git a/pdns/secpoll-auth.cc b/pdns/secpoll-auth.cc
index ca013f8310..19fd94e9fd 100644
--- a/pdns/secpoll-auth.cc
+++ b/pdns/secpoll-auth.cc
@@ -85,7 +85,7 @@ int doResolve(const string& qname, uint16_t qtype, vector<DNSResourceRecord>& re
   BOOST_FOREACH(ComboAddress& dest, s_secpollresolvers) {
     Socket sock(dest.sin4.sin_family, SOCK_DGRAM);
     sock.setNonBlocking();
-    sock.sendTo(string((char*)&*packet.begin(), (char*)&*packet.end()), dest);
+    sock.sendTo(string(packet.begin(), packet.end()), dest);
 
     string reply;