From: Victor Julien <victor@inliniac.net>
Date: Sun, 12 Apr 2020 09:25:12 +0000 (+0200)
Subject: atomics: avoid unnecessary (direct) CAS use
X-Git-Tag: suricata-6.0.0-beta1~511
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=109b2ae5517b249f6cc7a792cbe856762c5c6a1b;p=thirdparty%2Fsuricata.git

atomics: avoid unnecessary (direct) CAS use
---

diff --git a/src/suricata.c b/src/suricata.c
index bb92e2cf6c..a74d406505 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -2760,7 +2760,7 @@ int SuricataMain(int argc, char **argv)
         exit(EXIT_FAILURE);
     }
 
-    (void) SC_ATOMIC_CAS(&engine_stage, SURICATA_INIT, SURICATA_RUNTIME);
+    SC_ATOMIC_SET(engine_stage, SURICATA_RUNTIME);
     PacketPoolPostRunmodes();
 
     /* Un-pause all the paused threads */
@@ -2772,7 +2772,7 @@ int SuricataMain(int argc, char **argv)
     SuricataMainLoop(&suricata);
 
     /* Update the engine stage/status flag */
-    (void) SC_ATOMIC_CAS(&engine_stage, SURICATA_RUNTIME, SURICATA_DEINIT);
+    SC_ATOMIC_SET(engine_stage, SURICATA_DEINIT);
 
     UnixSocketKillSocketThread();
     PostRunDeinit(suricata.run_mode, &suricata.start_time);