From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 13 Nov 2017 10:12:01 +0000 (+0100)
Subject: install: drop redundant printing of unit name (#7296)
X-Git-Tag: v236~227
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=10d67460f5a6a0cf369ac6ffb31106de46424174;p=thirdparty%2Fsystemd.git

install: drop redundant printing of unit name (#7296)

We already print it as part of log_syntax() internal logic, don't print
it again, and in particular, don't print it at the end of log line, such
a strange place.

Follow-up for: 142468d89508c63262dd59335ea6d4fe82267564
---

diff --git a/src/shared/install.c b/src/shared/install.c
index ed0c4a5a11b..6a31e62c447 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
@@ -1223,7 +1223,7 @@ static int config_parse_default_instance(
                 return 0;
         if (!unit_name_is_valid(unit, UNIT_NAME_TEMPLATE))
                 return log_syntax(unit, LOG_WARNING, filename, line, 0,
-                                  "DefaultInstance= only makes sense for template units, ignoring. %s", unit);
+                                  "DefaultInstance= only makes sense for template units, ignoring.");
 
         r = install_full_printf(i, rvalue, &printed);
         if (r < 0)
@@ -2995,7 +2995,7 @@ static int preset_prepare_one(
         if (r < 0)
                 return r;
         if (!streq(name, i->name)) {
-                log_debug("Skipping %s because is an alias for %s", name, i->name);
+                log_debug("Skipping %s because it is an alias for %s.", name, i->name);
                 return 0;
         }