From: Jeremy Allison Date: Tue, 29 Sep 2020 03:06:04 +0000 (-0700) Subject: s3: smbd: SMB1 reply_copy() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense. X-Git-Tag: talloc-2.3.2~419 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=10e034ec21fc2fe1a3a23a769f17623b330c83e4;p=thirdparty%2Fsamba.git s3: smbd: SMB1 reply_copy() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense. There's either a wildcard in the last component or not. Always use UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard. Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme --- diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index fcac68147b1..db41bb54531 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -8697,9 +8697,9 @@ void reply_copy(struct smb_request *req) bool source_has_wild = False; bool dest_has_wild = False; NTSTATUS status; - uint32_t ucf_flags_src = UCF_COND_ALLOW_WCARD_LCOMP | + uint32_t ucf_flags_src = UCF_ALWAYS_ALLOW_WCARD_LCOMP | ucf_flags_from_smb_request(req); - uint32_t ucf_flags_dst = UCF_COND_ALLOW_WCARD_LCOMP | + uint32_t ucf_flags_dst = UCF_ALWAYS_ALLOW_WCARD_LCOMP | ucf_flags_from_smb_request(req); TALLOC_CTX *ctx = talloc_tos();