From: Mike Brady <mikebrady@eircom.net>
Date: Tue, 14 Mar 2017 10:38:48 +0000 (+0000)
Subject: Clean up creation of conversation thread -- no functional difference.
X-Git-Tag: 3.1.s5~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=10f3bc1eab19f1facbf69396b1280df2f91dc8e7;p=thirdparty%2Fshairport-sync.git

Clean up creation of conversation thread -- no functional difference.
---

diff --git a/rtsp.c b/rtsp.c
index ce4dab75..a02cc8d5 100644
--- a/rtsp.c
+++ b/rtsp.c
@@ -1974,18 +1974,15 @@ void rtsp_listen_loop(void) {
       } else {
         debug(1, "Error figuring out Shairport Sync's own IP number.");
       }
-
-      usleep(500000);
-      pthread_t rtsp_conversation_thread;
-      conn->stop = 0;
-      conn->authorized = 0;
+        usleep(500000);
+//      pthread_t rtsp_conversation_thread;
+//      conn->thread = rtsp_conversation_thread;
+//      conn->stop = 0; // record's memory has been zeroed 
+//      conn->authorized = 0; // record's memory has been zeroed 
       conn->running = 1;
-      ret = pthread_create(&rtsp_conversation_thread, NULL, rtsp_conversation_thread_func, conn);
+      ret = pthread_create(&conn->thread, NULL, rtsp_conversation_thread_func, conn); // also acts as a memory barrier
       if (ret)
         die("Failed to create RTSP receiver thread!");
-
-      conn->thread = rtsp_conversation_thread;
-      memory_barrier();
       track_thread(conn);
     }
   }