From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 29 Apr 2024 15:42:59 +0000 (+0100)
Subject: SQL connect_query is not expected to return data
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=10f93165175e5ba28cc25d5a48069255ea520b3a;p=thirdparty%2Ffreeradius-server.git

SQL connect_query is not expected to return data

So run with `rlm_sql_query()` rather than `rlm_sql_select_query()`
---

diff --git a/src/modules/rlm_sql/sql.c b/src/modules/rlm_sql/sql.c
index f2f0ff73c99..754dafda869 100644
--- a/src/modules/rlm_sql/sql.c
+++ b/src/modules/rlm_sql/sql.c
@@ -98,8 +98,15 @@ void *sql_mod_conn_create(TALLOC_CTX *ctx, void *instance, fr_time_delta_t timeo
 	}
 
 	if (inst->config.connect_query) {
-		if (rlm_sql_select_query(inst, NULL, &handle, inst->config.connect_query) != RLM_SQL_OK) goto fail;
-		(inst->driver->sql_finish_select_query)(handle, &inst->config);
+		fr_sql_query_t	*query_ctx;
+		rlm_rcode_t	p_result;
+		MEM(query_ctx = fr_sql_query_alloc(ctx, inst, handle, inst->config.connect_query, SQL_QUERY_OTHER));
+		rlm_sql_query(&p_result, NULL, NULL, query_ctx);
+		if (query_ctx->rcode != RLM_SQL_OK) {
+			talloc_free(query_ctx);
+			goto fail;
+		}
+		talloc_free(query_ctx);
 	}
 
 	return handle;