From: Gord Thompson <gord@gordthompson.com>
Date: Wed, 8 Apr 2020 11:40:36 +0000 (-0600)
Subject: Fix distinct_from test for Firebird et al.
X-Git-Tag: rel_1_4_0b1~402^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=10fb4d4d2f755d813993852b8cb9de3a9c0a2b3f;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Fix distinct_from test for Firebird et al.

Firebird (and perhaps others) allow us to CREATE TABLE inside a transaction but we can't INSERT INTO that table unless we COMMIT first.

Change-Id: Ie8127ef29f1ec91e7afb88e1429538c27a321784
---

diff --git a/lib/sqlalchemy/testing/suite/test_select.py b/lib/sqlalchemy/testing/suite/test_select.py
index f9363d7020..2c2317ff76 100644
--- a/lib/sqlalchemy/testing/suite/test_select.py
+++ b/lib/sqlalchemy/testing/suite/test_select.py
@@ -1036,7 +1036,7 @@ class IsOrIsNotDistinctFromTest(fixtures.TablesTest):
             Column("col_a", Integer, nullable=True),
             Column("col_b", Integer, nullable=True),
         )
-        tbl.create(connection)
+        meta.create_all()
         connection.execute(
             tbl.insert(),
             [{"id": 1, "col_a": col_a_value, "col_b": col_b_value}],