From: lpsolit%gmail.com <> Date: Tue, 22 Nov 2005 03:39:09 +0000 (+0000) Subject: Bug 279716: Users have to relogin when changing their own password - Patch by Marc... X-Git-Tag: bugzilla-2.20.1~85 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=110e71e6bd33f6d427d4f0c369f6fc2db1c1aaa5;p=thirdparty%2Fbugzilla.git Bug 279716: Users have to relogin when changing their own password - Patch by Marc Schumann r=wicked a=justdave --- diff --git a/Bugzilla/Auth/Login/WWW/CGI.pm b/Bugzilla/Auth/Login/WWW/CGI.pm index 00d5e382ac..22b2bf1fbd 100644 --- a/Bugzilla/Auth/Login/WWW/CGI.pm +++ b/Bugzilla/Auth/Login/WWW/CGI.pm @@ -195,6 +195,7 @@ sub can_logout { return 1; } sub logout { my ($class, $user, $option) = @_; my $dbh = Bugzilla->dbh; + my $cgi = Bugzilla->cgi; $option = LOGOUT_ALL unless defined $option; if ($option == LOGOUT_ALL) { @@ -203,8 +204,17 @@ sub logout { return; } - # The LOGOUT_*_CURRENT options require a cookie - my $cookie = Bugzilla->cgi->cookie("Bugzilla_logincookie"); + # The LOGOUT_*_CURRENT options require the current login cookie. + # If a new cookie has been issued during this run, that's the current one. + # If not, it's the one we've received. + my $cookie; + foreach (@{$cgi->{'Bugzilla_cookie_list'}}) { + if ($_->name() eq 'Bugzilla_logincookie') { + $cookie = $_->value(); + last; + } + } + $cookie ||= $cgi->cookie("Bugzilla_logincookie"); detaint_natural($cookie); # These queries use both the cookie ID and the user ID as keys. Even