From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 6 Apr 2024 22:18:04 +0000 (-0700)
Subject: split: don’t trust st_size on /proc files
X-Git-Tag: v9.6~256
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11163675818ab877f20d3740a7c3e59d565b8e9c;p=thirdparty%2Fcoreutils.git

split: don’t trust st_size on /proc files

* src/split.c (create): Don’t trust st_size == 0.
---

diff --git a/src/split.c b/src/split.c
index 037960a594..f82a7f74b4 100644
--- a/src/split.c
+++ b/src/split.c
@@ -489,10 +489,8 @@ create (char const *name)
       if (psame_inode (&in_stat_buf, &out_stat_buf))
         error (EXIT_FAILURE, 0, _("%s would overwrite input; aborting"),
                quoteaf (name));
-      bool regularish
-        = S_ISREG (out_stat_buf.st_mode) || S_TYPEISSHM (&out_stat_buf);
-      if (! (regularish && out_stat_buf.st_size == 0)
-          && ftruncate (fd, 0) < 0 && regularish)
+      if (ftruncate (fd, 0) < 0
+          && (S_ISREG (out_stat_buf.st_mode) || S_TYPEISSHM (&out_stat_buf)))
         error (EXIT_FAILURE, errno, _("%s: error truncating"), quotef (name));
 
       return fd;