From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 21 Jul 2017 20:23:23 +0000 (+0200)
Subject: util: Log return code of commands only if something failed
X-Git-Tag: 009~124
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11285da05d7e0227225f4966a58e56edcdc2dca1;p=network.git

util: Log return code of commands only if something failed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/functions/functions.util b/src/functions/functions.util
index 28396f07..eb2b863f 100644
--- a/src/functions/functions.util
+++ b/src/functions/functions.util
@@ -415,12 +415,14 @@ cmd() {
 
 	log DEBUG "Running command: ${cmd}"
 
-	${cmd}
-	local ret=$?
+	if ! ${cmd}; then
+		local ret=$?
 
-	log DEBUG "Returned with code '${ret}'"
+		log DEBUG "Returned with code '${ret}'"
+		return ${ret}
+	fi
 
-	return ${ret}
+	return ${EXIT_OK}
 }
 
 cmd_quiet() {