From: Jeremy Allison Date: Fri, 28 Oct 2022 22:31:39 +0000 (-0700) Subject: s3: libsmbclient: Fix smbc_getxattr() to return 0 on success. X-Git-Tag: samba-4.16.9~23 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=113536e0d735a5235f8be29d4fd1cfc8177930b1;p=thirdparty%2Fsamba.git s3: libsmbclient: Fix smbc_getxattr() to return 0 on success. Remove knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14808 Signed-off-by: Jeremy Allison Reviewed-by: David Mulder Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Nov 1 18:31:22 UTC 2022 on sn-devel-184 (cherry picked from commit bdbb38d16c8eaff33484bb747efa639c4d8e7f35) --- diff --git a/selftest/knownfail.d/libsmbclient_getxattr b/selftest/knownfail.d/libsmbclient_getxattr deleted file mode 100644 index f27656f4ce4..00000000000 --- a/selftest/knownfail.d/libsmbclient_getxattr +++ /dev/null @@ -1 +0,0 @@ -^samba4.libsmbclient.getxattr.* diff --git a/source3/libsmb/libsmb_xattr.c b/source3/libsmb/libsmb_xattr.c index d66ea63617c..c7091ffaca2 100644 --- a/source3/libsmb/libsmb_xattr.c +++ b/source3/libsmb/libsmb_xattr.c @@ -2176,7 +2176,11 @@ SMBC_getxattr_ctx(SMBCCTX *context, errno = SMBC_errno(context, srv->cli); } TALLOC_FREE(frame); - return ret; + /* + * static function cacl_get returns a value greater than zero + * on success. Map this to zero meaning success. + */ + return ret < 0 ? -1 : 0; } /* Unsupported attribute name */