From: Darren Tucker <dtucker@dtucker.net>
Date: Thu, 11 Aug 2022 03:33:51 +0000 (+1000)
Subject: Skip hostbased during Valgrind tests.
X-Git-Tag: V_9_1_P1~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=113fe6c77ab43769fc61e953d07cb619fd7ea54b;p=thirdparty%2Fopenssh-portable.git

Skip hostbased during Valgrind tests.

Valgrind doesn't let ssh exec ssh-keysign (because it's setuid) so skip
it during the Valgrind based tests.

See https://bugs.kde.org/show_bug.cgi?id=119404 for a discussion of this
(ironically there the problematic binary was ssh(1) back when it could
still be setuid).
---

diff --git a/.github/configs b/.github/configs
index 48070ee75..a853c6329 100755
--- a/.github/configs
+++ b/.github/configs
@@ -166,8 +166,9 @@ case "$config" in
 	case "$config" in
 	    valgrind-1)
 		# All tests except agent-timeout (which is flaky under valgrind)
-		#) and slow ones that run separately to increase parallelism.
-		SKIP_LTESTS="agent-timeout ${tests2} ${tests3} ${tests4}"
+		# and hostbased (since valgrind won't let ssh exec keysign).
+		# Slow ones are run separately to increase parallelism.
+		SKIP_LTESTS="agent-timeout hostbased ${tests2} ${tests3} ${tests4}"
 		;;
 	    valgrind-2)
 		LTESTS="${tests2}"