From: Eric Sandeen <sandeen@redhat.com>
Date: Tue, 25 Oct 2016 01:47:14 +0000 (+1100)
Subject: xfs: remove pointless error goto in xfs_bmap_remap_alloc
X-Git-Tag: v4.9.0-rc1~70
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=114c49821dfe4cdd30e92988b22f738025cf94cd;p=thirdparty%2Fxfsprogs-dev.git

xfs: remove pointless error goto in xfs_bmap_remap_alloc

Source kernel commit: fe23759eaf2f6540de20c1623f066aad967ff9c9

The commit:

f65306ea xfs: map an inode's offset to an exact physical block

added a pointless error0: target; remove it.

Addresses-Coverity-Id: 1373865
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c
index 427cd2fbe..d2b371a31 100644
--- a/libxfs/xfs_bmap.c
+++ b/libxfs/xfs_bmap.c
@@ -3966,9 +3966,6 @@ xfs_bmap_remap_alloc(
 	 * allocating, so skip that check by pretending to be freeing.
 	 */
 	error = xfs_alloc_fix_freelist(&args, XFS_ALLOC_FLAG_FREEING);
-	if (error)
-		goto error0;
-error0:
 	xfs_perag_put(args.pag);
 	if (error)
 		trace_xfs_bmap_remap_alloc_error(ap->ip, error, _RET_IP_);