From: Stefano Lattarini Date: Fri, 27 Jul 2012 14:19:47 +0000 (+0200) Subject: [ng] check: prefer '#' over '##' for some comments X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=115281f351a1b55811b627d313e041f56ba1148e;p=thirdparty%2Fautomake.git [ng] check: prefer '#' over '##' for some comments * lib/am/parallel-tests.am: Here. This will make it easier for someone reading the generated Makefile.in to understand what is going on. --- diff --git a/lib/am/parallel-tests.am b/lib/am/parallel-tests.am index 87244341e..6bad73671 100644 --- a/lib/am/parallel-tests.am +++ b/lib/am/parallel-tests.am @@ -60,14 +60,14 @@ am.test-suite.runtest = \ "$$tst" \ $(AM_TESTS_FD_REDIRECT) -## Turn e.g., ".test" in "_TEST", and return the empty string unchanged. +# Turn e.g., ".test" in "_TEST", and return the empty string unchanged. am__tpfx = \ $(if $1,$(call am.util.toupper,$(patsubst .%,%_,$1))) define am.test-suite.handle-suffix -## FIXME: This will pick up the default from the environment; are we sure -## FIXME: we want that? +# FIXME: This will pick up the default from the environment; are we sure +# FIXME: we want that? $$(call am__tpfx,$1)LOG_DRIVER ?= $(SHELL) $(am.conf.aux-dir)/test-driver %.log %.trs: %$1 $$($$(call am__tpfx,$1)LOG_DEPENDENCIES) @@ -82,19 +82,19 @@ endif # am.conf.handle-exeext = yes endef # am.test-suite.handle-suffix -## FIXME: this will pick up the default from the environment; are we sure -## FIXME: we want that? +# FIXME: this will pick up the default from the environment; are we sure +# FIXME: we want that? TEST_EXTENSIONS ?= .test $(foreach e,$(filter-out .%,$(TEST_EXTENSIONS)),\ $(call am.error,invalid test extension: '$e')) $(foreach e,$(TEST_EXTENSIONS), \ $(eval $(call am.test-suite.handle-suffix,$e))) -## It is *imperative* that the "empty" suffix goes last. Otherwise, a -## declaration like "TESTS = all.test" would cause GNU make to mistakenly -## try to build the 'all.log' and 'all.trs' files from a non-existent -## 'all' program (because the Makefile contains an explicit 'all' target, -## albeit .PHONY), rather than from the 'all.test' script, thus causing -## all sort of mishaps and confusion. +# It is *imperative* that the "empty" suffix goes last. Otherwise, a +# declaration like "TESTS = all.test" would cause GNU make to mistakenly +# try to build the 'all.log' and 'all.trs' files from a non-existent +# 'all' program (because the Makefile contains an explicit 'all' target, +# albeit .PHONY), rather than from the 'all.test' script, thus causing +# all sort of mishaps and confusion. $(eval $(call am.test-suite.handle-suffix)) # The names of the given tests scripts with any possible registered @@ -438,8 +438,8 @@ check-TESTS: $(MAKE) $(TEST_SUITE_LOG) .PHONY: check-TESTS -## Recheck must depend on $(check_SCRIPTS), $(check_PROGRAMS), etc. -## It must also depend on the 'all' target. See automake bug#11252. +# Recheck must depend on $(check_SCRIPTS), $(check_PROGRAMS), etc. +# It must also depend on the 'all' target. See automake bug#11252. recheck: all %CHECK-DEPS% +$(am.setup-test-harness-workdir) ## See comments above in the check-TESTS recipe for why remove @@ -455,12 +455,12 @@ recheck: all %CHECK-DEPS% $(TEST_SUITE_LOG) .am/doing-recheck=yes .PHONY: recheck -## One tricky requirement of the "recheck" target is that, in case (say) -## the test is a compiled program whose compilation fails, we must ensure -## that any '.log' and '.trs' file referring to such test are preserved, -## so that future "make recheck" invocations will still try to re-compile -## and re-run it (automake bug#11791). This indirection is aimed at -## satisfying such a requirement. +# One tricky requirement of the "recheck" target is that, in case (say) +# the test is a compiled program whose compilation fails, we must ensure +# that any '.log' and '.trs' file referring to such test are preserved, +# so that future "make recheck" invocations will still try to re-compile +# and re-run it (automake bug#11791). This indirection is aimed at +# satisfying such a requirement. ifeq ($(.am/doing-recheck),yes) $(am.test-suite.test-logs) $(am.test-suite.test-results): .am/nil endif