From: Julian Seward <jseward@acm.org>
Date: Fri, 17 Aug 2018 06:40:40 +0000 (+0200)
Subject: On x86: enable by default, expensive-when-needed instrumentation of Add32.
X-Git-Tag: VALGRIND_3_14_0~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=117b395382ba65bf54d6f0497560562ef1f57a24;p=thirdparty%2Fvalgrind.git

On x86: enable by default, expensive-when-needed instrumentation of Add32.

This reduces Memcheck's false-positive level a lot on clang -O2 generated
code.
---

diff --git a/memcheck/mc_translate.c b/memcheck/mc_translate.c
index 6667191600..5ed39ae21e 100644
--- a/memcheck/mc_translate.c
+++ b/memcheck/mc_translate.c
@@ -8104,6 +8104,7 @@ IRSB* MC_(instrument) ( VgCallbackClosure* closure,
          are used only to construct memory addresses, which is an
          approximation to the above, and is self-contained.*/
 #     if defined(VGA_x86)
+      mce.dlbo.dl_Add32           = DLauto;
       mce.dlbo.dl_CmpEQ32_CmpNE32 = DLexpensive;
 #     elif defined(VGA_amd64)
       mce.dlbo.dl_Add64           = DLauto;