From: Frédéric Buclin <LpSolit@gmail.com>
Date: Mon, 18 Feb 2013 12:26:51 +0000 (+0100)
Subject: Bug 842063: HTML injection is possible using the bug alias
X-Git-Tag: bugzilla-4.5.1~199
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11829ac0a3822b246b76c00375c7e4137f9af33b;p=thirdparty%2Fbugzilla.git

Bug 842063: HTML injection is possible using the bug alias
r=dkl a=LpSolit
---

diff --git a/template/en/default/bug/show-header.html.tmpl b/template/en/default/bug/show-header.html.tmpl
index 54d51dd4f3..f67bbf2f88 100644
--- a/template/en/default/bug/show-header.html.tmpl
+++ b/template/en/default/bug/show-header.html.tmpl
@@ -13,12 +13,14 @@
   # be overridden by the calling templates.
   #%]
 
+[% filtered_alias = bug.alias FILTER html %]
 [% filtered_desc = bug.short_desc FILTER html %]
-[% subheader = filtered_desc %]
 [% filtered_timestamp = bug.delta_ts FILTER time %]
+
+[% subheader = filtered_desc %]
 [% title = "$terms.Bug $bug.bug_id &ndash; " %]
 [% IF bug.alias != '' %]
-  [% title = title _ "($bug.alias) " %]
+  [% title = title _ "($filtered_alias) " %]
 [% END %]
 [% title = title _ filtered_desc %]
 [% yui = ['autocomplete', 'calendar'] %]