From: Greg Ames Date: Thu, 9 Dec 2004 14:11:29 +0000 (+0000) Subject: ap_queue_push: update comment to reflect reality X-Git-Tag: 2.1.3~291 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1192058be2fdbf8b96b023041da30f894bc8ceed;p=thirdparty%2Fapache%2Fhttpd.git ap_queue_push: update comment to reflect reality pointed out by: Ron Park (ronp cnet.com) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111385 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/server/mpm/experimental/event/fdqueue.c b/server/mpm/experimental/event/fdqueue.c index 8ffc5114ee6..8802daf7a55 100644 --- a/server/mpm/experimental/event/fdqueue.c +++ b/server/mpm/experimental/event/fdqueue.c @@ -307,9 +307,10 @@ apr_status_t ap_queue_init(fd_queue_t * queue, int queue_capacity, } /** - * Push a new socket onto the queue. Blocks if the queue is full. Once - * the push operation has completed, it signals other threads waiting - * in ap_queue_pop() that they may continue consuming sockets. + * Push a new socket onto the queue. + * + * precondition: ap_queue_info_wait_for_idler has already been called + * to reserve an idle worker thread */ apr_status_t ap_queue_push(fd_queue_t * queue, apr_socket_t * sd, conn_state_t * cs, apr_pool_t * p) diff --git a/server/mpm/worker/fdqueue.c b/server/mpm/worker/fdqueue.c index b747c63e9b2..d2d271513a3 100644 --- a/server/mpm/worker/fdqueue.c +++ b/server/mpm/worker/fdqueue.c @@ -275,9 +275,10 @@ apr_status_t ap_queue_init(fd_queue_t *queue, int queue_capacity, apr_pool_t *a) } /** - * Push a new socket onto the queue. Blocks if the queue is full. Once - * the push operation has completed, it signals other threads waiting - * in ap_queue_pop() that they may continue consuming sockets. + * Push a new socket onto the queue. + * + * precondition: ap_queue_info_wait_for_idler has already been called + * to reserve an idle worker thread */ apr_status_t ap_queue_push(fd_queue_t *queue, apr_socket_t *sd, apr_pool_t *p) {